From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: drepper@redhat.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, davidel@xmailserver.org,
mtk.manpages@gmail.com, torvalds@linux-foundation.org
Subject: Re: [PATCH 18/18] flag parameters: check magic constants
Date: Mon, 12 May 2008 20:45:47 -0700 (PDT) [thread overview]
Message-ID: <20080512.204547.138851614.davem@davemloft.net> (raw)
In-Reply-To: <20080512201341.9ead6a9a.akpm@linux-foundation.org>
From: Andrew Morton <akpm@linux-foundation.org>
Date: Mon, 12 May 2008 20:13:41 -0700
> On Tue, 6 May 2008 17:18:07 -0400 Ulrich Drepper <drepper@redhat.com> wrote:
>
> > --- a/net/socket.c
> > +++ b/net/socket.c
> > @@ -1219,6 +1219,13 @@ asmlinkage long sys_socket(int family, int type, int protocol)
> > struct socket *sock;
> > int flags;
> >
> > + /* Check the SOCK_* constants for consistency. */
> > + BUILD_BUG_ON(SOCK_CLOEXEC != O_CLOEXEC);
> > + BUILD_BUG_ON(SOCK_NONBLOCK != O_NONBLOCK);
> > + BUILD_BUG_ON((SOCK_MAX | SOCK_TYPE_MASK) != SOCK_TYPE_MASK);
> > + BUILD_BUG_ON(SOCK_CLOEXEC & SOCK_TYPE_MASK);
> > + BUILD_BUG_ON(SOCK_NONBLOCK & SOCK_TYPE_MASK);
>
> The fifth assertion triggers with alpha allmodconfig.
Unfortunately, MIPS and PARISC look like they will as well :-/
next prev parent reply other threads:[~2008-05-13 3:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-06 21:18 [PATCH 18/18] flag parameters: check magic constants Ulrich Drepper
2008-05-13 3:13 ` Andrew Morton
2008-05-13 3:45 ` David Miller [this message]
2008-05-13 3:54 ` Ulrich Drepper
2008-05-13 4:01 ` Andrew Morton
2008-05-13 4:02 ` David Miller
2008-05-13 4:21 ` Ulrich Drepper
2008-05-13 4:39 ` David Miller
2008-05-13 5:04 ` Andrew Morton
2008-05-13 5:10 ` Ulrich Drepper
2008-05-13 5:19 ` Andrew Morton
2008-05-13 5:42 ` Ulrich Drepper
2008-05-14 4:43 ` Andrew Morton
2008-05-23 5:22 ` Andrew Morton
2008-05-23 14:31 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080512.204547.138851614.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=davidel@xmailserver.org \
--cc=drepper@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).