From: David Miller <davem@davemloft.net>
To: yjwei@cn.fujitsu.com
Cc: vladislav.yasevich@hp.com, kaber@trash.net,
netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
lksctp-developers@lists.sourceforge.net
Subject: Re: [PATCH] [SCTP]: Add address type check while process paramaters of ASCONF chunk
Date: Tue, 13 May 2008 18:14:15 -0700 (PDT) [thread overview]
Message-ID: <20080513.181415.228379595.davem@davemloft.net> (raw)
In-Reply-To: <482A38B5.5030908@cn.fujitsu.com>
From: Wei Yongjun <yjwei@cn.fujitsu.com>
Date: Wed, 14 May 2008 08:56:21 +0800
> Hi David:
>
> Sorry for my mistake. This patch is create and tested by me.
>
> I tested it used a test tool which is created by me. And this patchset
> resolved the kernel panic problem. It seems that I need to do more
> review my patch and
> add more test case to my tool. I will pay more attention to do the
> correct patchs.
It dereferences an uninitialized pointer, unconditionally. Therefore,
the patch was definitely completely untested. This function never ran
during your tests.
Please, no more excuses.
You didn't test the patch.
The end.
next prev parent reply other threads:[~2008-05-14 1:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-09 19:09 [PATCH] [SCTP]: Do not enable peer IPv6 address support on PF_INET socket Vlad Yasevich
2008-05-09 19:09 ` [PATCH] [SCTP]: Add address type check while process paramaters of ASCONF chunk Vlad Yasevich
2008-05-09 22:12 ` David Miller
2008-05-13 11:30 ` Patrick McHardy
2008-05-13 12:48 ` Vlad Yasevich
2008-05-13 22:32 ` David Miller
2008-05-14 0:56 ` Wei Yongjun
2008-05-14 1:14 ` David Miller [this message]
2008-05-14 1:49 ` Wei Yongjun
2008-05-14 6:25 ` David Miller
2008-05-09 22:11 ` [PATCH] [SCTP]: Do not enable peer IPv6 address support on PF_INET socket David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080513.181415.228379595.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=linux-sctp@vger.kernel.org \
--cc=lksctp-developers@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=vladislav.yasevich@hp.com \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).