From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] [SCTP]: Add address type check while process
 paramaters of ASCONF chunk
Date: Tue, 13 May 2008 18:14:15 -0700 (PDT)
Message-ID: <20080513.181415.228379595.davem@davemloft.net>
References: <48298E27.40100@hp.com>
	<20080513.153238.211668684.davem@davemloft.net>
	<482A38B5.5030908@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: vladislav.yasevich@hp.com, kaber@trash.net, netdev@vger.kernel.org,
	linux-sctp@vger.kernel.org, lksctp-developers@lists.sourceforge.net
To: yjwei@cn.fujitsu.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:39970
	"EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK)
	by vger.kernel.org with ESMTP id S1757686AbYENBOV (ORCPT
	<rfc822;netdev@vger.kernel.org>); Tue, 13 May 2008 21:14:21 -0400
In-Reply-To: <482A38B5.5030908@cn.fujitsu.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Wei Yongjun <yjwei@cn.fujitsu.com>
Date: Wed, 14 May 2008 08:56:21 +0800

> Hi David:
> 
>  Sorry for my mistake. This patch is create and tested by me.
> 
>  I tested it used a test tool which is created by me. And this patchset 
> resolved the kernel panic problem. It seems that I need to do more 
> review my patch and
> add more test case to my tool. I will pay more attention to do the 
> correct patchs.

It dereferences an uninitialized pointer, unconditionally.  Therefore,
the patch was definitely completely untested.  This function never ran
during your tests.

Please, no more excuses.

You didn't test the patch.
The end.