* [PATCH][PPP]: Do not free not yet unregistered net device.
@ 2008-05-13 15:30 Pavel Emelyanov
2008-05-14 6:51 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Emelyanov @ 2008-05-13 15:30 UTC (permalink / raw)
To: David Miller; +Cc: Linux Netdev List
An error path in ppp_create_interface() lacks one and may
BUG in free_netdev() checking for proper dev->reg_state.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
diff --git a/drivers/net/ppp_generic.c b/drivers/net/ppp_generic.c
index d3207c0..1f4ca2b 100644
--- a/drivers/net/ppp_generic.c
+++ b/drivers/net/ppp_generic.c
@@ -2458,6 +2458,7 @@ ppp_create_interface(int unit, int *retp)
out3:
atomic_dec(&ppp_unit_count);
+ unregister_netdev(dev);
out2:
mutex_unlock(&all_ppp_mutex);
free_netdev(dev);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][PPP]: Do not free not yet unregistered net device.
2008-05-13 15:30 [PATCH][PPP]: Do not free not yet unregistered net device Pavel Emelyanov
@ 2008-05-14 6:51 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-05-14 6:51 UTC (permalink / raw)
To: xemul; +Cc: netdev
From: Pavel Emelyanov <xemul@openvz.org>
Date: Tue, 13 May 2008 19:30:50 +0400
> An error path in ppp_create_interface() lacks one and may
> BUG in free_netdev() checking for proper dev->reg_state.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied, thanks a lot Pavel.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-14 6:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-13 15:30 [PATCH][PPP]: Do not free not yet unregistered net device Pavel Emelyanov
2008-05-14 6:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).