netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: Wei Yongjun <yjwei@cn.fujitsu.com>
Cc: dccp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] DCCP: Fix to reset the connection with Reset Code 5 Option Error while receive invalid option
Date: Tue, 13 May 2008 09:30:33 +0100	[thread overview]
Message-ID: <20080513083033.GA11707@gerrit.erg.abdn.ac.uk> (raw)
In-Reply-To: <48294E9C.4060209@cn.fujitsu.com>

Quoting Wei Yongjun:
> If endpoint received invalid option, it must reset the connection with  
> Reset Code 5 "Option Error", but current kernel send reset with Reset  
> Code 4 "Packet Error".
>
Ack. However, this has already been fixed in the test tree where dccp_parse()
both sets the Reset code and fills in the Data1..3 fields (not done by this patch).

Within a span of two weeks this is the fourth DCCP patch which fixes bugs
that already have fixes in the DCCP test tree. The same problems are fixed
in two different locations.

If you are doing DCCP work, please consider 
http://www.linux-foundation.org/en/Net:DCCP_Testing#How_to_obtain

  reply	other threads:[~2008-05-13  8:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-13  8:17 [PATCH] DCCP: Fix to reset the connection with Reset Code 5 Option Error while receive invalid option Wei Yongjun
2008-05-13  8:30 ` Gerrit Renker [this message]
2008-05-13  9:57   ` Wei Yongjun
2008-05-13 10:32     ` Gerrit Renker
2008-05-13 10:52       ` Wei Yongjun
2008-05-13 11:04         ` Macro mismatch in test tree Gerrit Renker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080513083033.GA11707@gerrit.erg.abdn.ac.uk \
    --to=gerrit@erg.abdn.ac.uk \
    --cc=dccp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yjwei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).