netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-2.6.26] Fix typo in net/core/sock.c.
@ 2008-05-14  9:27 Rami Rosen
  2008-05-14 10:50 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Rami Rosen @ 2008-05-14  9:27 UTC (permalink / raw)
  To: David Miller, netdev

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

Hi,

In sock_queue_rcv_skb()  (net/core/sock.c) it should be:
"Cast sk->rcvbuf ..." instead of: "Cast skb->rcvbuf ..."


Regards,
Rami Rosen


Signed-off-by: Rami Rosen <ramirose@gmail.com>

[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 479 bytes --]

diff --git a/net/core/sock.c b/net/core/sock.c
index fa76f04..88094cb 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -270,7 +270,7 @@ int sock_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
 	int err = 0;
 	int skb_len;
 
-	/* Cast skb->rcvbuf to unsigned... It's pointless, but reduces
+	/* Cast sk->rcvbuf to unsigned... It's pointless, but reduces
 	   number of warnings when compiling with -W --ANK
 	 */
 	if (atomic_read(&sk->sk_rmem_alloc) + skb->truesize >=

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-2.6.26] Fix typo in net/core/sock.c.
  2008-05-14  9:27 [PATCH net-2.6.26] Fix typo in net/core/sock.c Rami Rosen
@ 2008-05-14 10:50 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-05-14 10:50 UTC (permalink / raw)
  To: ramirose; +Cc: netdev

From: "Rami Rosen" <ramirose@gmail.com>
Date: Wed, 14 May 2008 12:27:47 +0300

> In sock_queue_rcv_skb()  (net/core/sock.c) it should be:
> "Cast sk->rcvbuf ..." instead of: "Cast skb->rcvbuf ..."
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>

Comment typo patches cannot cause regressions (usually :-)
so it's OK to add them to net-2.6

And therefore that's where I've applied this.

Thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-05-14 10:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-14  9:27 [PATCH net-2.6.26] Fix typo in net/core/sock.c Rami Rosen
2008-05-14 10:50 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).