From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: netdev@vger.kernel.org, mark.asselstine@windriver.com, kkeil@suse.de
Subject: Re: [patch 4/8] hysdn: remove cli()/sti() calls
Date: Wed, 14 May 2008 16:41:40 -0700 (PDT) [thread overview]
Message-ID: <20080514.164140.229890751.davem@davemloft.net> (raw)
In-Reply-To: <200805142319.m4ENJh0C026560@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Wed, 14 May 2008 16:19:43 -0700
> From: Mark Asselstine <mark.asselstine@windriver.com>
>
> The use of cli()/sti() within the do/while was a way to ensure interrupts were
> only disabled for short periods of time while the bulk of the time interrupts
> were free to occur. The use of the spin lock has eliminated the need to play
> with interrupts in this way while still allowing for IO to be protected.
>
> The remaining 3 sti() calls seem unneeded now that at no other point in the
> driver is there a call to cli().
>
> Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
> Acked-by: Karsten Keil <kkeil@suse.de>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: David S. Miller <davem@davemloft.net>
prev parent reply other threads:[~2008-05-14 23:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 23:19 [patch 4/8] hysdn: remove cli()/sti() calls akpm
2008-05-14 23:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080514.164140.229890751.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=kkeil@suse.de \
--cc=mark.asselstine@windriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).