From: Arjan van de Ven <arjan@infradead.org>
To: "Christophe Jaillet" <christophe.jaillet@wanadoo.fr>
Cc: "cj" <christophe.jaillet@wanadoo.fr>,
"linux" <linux-kernel@vger.kernel.org>,
<florian.fainelli@telecomint.eu>, <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/1] /drivers/net/r6040.c: bad use of round_jiffies() ???
Date: Thu, 15 May 2008 14:43:13 -0700 [thread overview]
Message-ID: <20080515144313.524d199d@infradead.org> (raw)
In-Reply-To: <20080515212624.D56371C00093@mwinf2723.orange.fr>
On Thu, 15 May 2008 23:26:22 +0200
"Christophe Jaillet" <christophe.jaillet@wanadoo.fr> wrote:
> From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
>
> Hi, here is a patch against linux/drivers/net/r6040.c.
>
> Compared to other places in the kernel, I think that this driver
> misuses the function round_jiffies.
>
>
> Note: this patch is based on 'linux-2.6.25.tar.bz2'
>
> Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
>
> ---
>
> --- linux 2.6.25/drivers/net/r6040.c 2008-05-15
> 23:21:28.000000000 +0200 +++ linux
> 2.6.25/drivers/net/r6040.c.cj 2008-05-15 22:16:44.000000000
> +0200 @@ -733,7 +733,7 @@ static void r6040_timer(unsigned long da }
>
> /* Timer active again */
> - mod_timer(&lp->timer, jiffies + round_jiffies(HZ));
> + mod_timer(&lp->timer, round_jiffies(jiffies + HZ));
> }
>
good catch!
Acked-by: Arjan van de Ven <arjan@linux.intel.com>
next prev parent reply other threads:[~2008-05-15 21:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 21:26 [PATCH 1/1] /drivers/net/r6040.c: bad use of round_jiffies() ??? Christophe Jaillet
2008-05-15 21:31 ` Florian Fainelli
2008-05-15 21:43 ` Arjan van de Ven [this message]
2008-06-12 2:50 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080515144313.524d199d@infradead.org \
--to=arjan@infradead.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=florian.fainelli@telecomint.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).