From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 1/6] [BNX2]: Allow phy reset to be skipped during chip reset. Date: Fri, 16 May 2008 22:17:52 -0700 (PDT) Message-ID: <20080516.221752.201026485.davem@davemloft.net> References: <1210973376.5507.17.camel@dell> <20080516213430.GC20212@gospo.usersys.redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: mchan@broadcom.com, netdev@vger.kernel.org, benli@broadcom.com To: andy@greyhouse.net Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:46926 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751391AbYEQFR6 (ORCPT ); Sat, 17 May 2008 01:17:58 -0400 In-Reply-To: <20080516213430.GC20212@gospo.usersys.redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Andy Gospodarek Date: Fri, 16 May 2008 17:34:30 -0400 > On Fri, May 16, 2008 at 02:29:36PM -0700, Michael Chan wrote: > > [BNX2]: Allow phy reset to be skipped during chip reset. > > > > Andy Gospodarek found that netconsole would > > panic when resetting bnx2 devices. > > > > >From Andy: > > "The issue is the bnx2_set_link in bnx2_init_nic will print a link-status > > message before we are fully initialized and ready to start polling. > > Polling is currently disabled in this state, but since the > > __LINK_STATE_RX_SCHED is overloaded to not only try and disable polling > > but also to make the system aware there is something waiting to be > > polled, we really have to fix this in drivers. > > > > The problematic call is the one to netif_rx_complete as it tries to > > remove an entry from the poll_list when there isn't one." > > > > While this netconsole problem should be fixed separately, we really > > should not reset the PHY when changing ring sizes, MTU, or other > > similar settings. The PHY reset causes several seconds of unnecessary > > link disruptions. > > > > Signed-off-by: Michael Chan > > Cc: Andy Gospodarek > > Acked-by: Andy Gospodarek Applied, thanks everyone.