From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: bhutchings@solarflare.com, netdev@vger.kernel.org,
andy@greyhouse.net, benli@broadcom.com
Subject: Re: [PATCH net-next 3/6 revised] [BNX2]: Remove the rx_offset field from the bnx2 structure.
Date: Fri, 16 May 2008 22:19:11 -0700 (PDT) [thread overview]
Message-ID: <20080516.221911.49059141.davem@davemloft.net> (raw)
In-Reply-To: <1210976321.5938.16.camel@dell>
From: "Michael Chan" <mchan@broadcom.com>
Date: Fri, 16 May 2008 15:18:41 -0700
> [BNX2]: Remove the rx_offset field from the bnx2 structure.
>
> The rx_offset field is set to a constant value and initialized
> only once. By replacing all references to the rx_offset field,
> we can eliminate rx_offset from the bnx2 structure. This will
> save 4 bytes for every bnx2 instance.
>
> [Added parentheses to the definition of BNX2_RX_OFFSET, as noted
> by Ben Hutchings.]
>
> Signed-off-by: Benjamin Li <benli@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied, thanks for respinning this patch Michael.
prev parent reply other threads:[~2008-05-17 5:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 21:30 [PATCH net-next 3/6] [BNX2]: Remove the rx_offset field from the bnx2 structure Michael Chan
2008-05-16 20:29 ` Ben Hutchings
2008-05-16 22:07 ` Michael Chan
2008-05-16 22:18 ` [PATCH net-next 3/6 revised] " Michael Chan
2008-05-17 5:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080516.221911.49059141.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=benli@broadcom.com \
--cc=bhutchings@solarflare.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).