netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Ilpo J?rvinen <ilpo.jarvinen@helsinki.fi>
Cc: Subbu Seetharaman <subbus@serverengines.com>,
	Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/15] BE NIC driver - header and initialization functions
Date: Fri, 16 May 2008 06:06:42 -0400	[thread overview]
Message-ID: <20080516100642.GA18884@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0805161146110.1888@wrl-59.cs.helsinki.fi>

On Fri, May 16, 2008 at 12:54:11PM +0300, Ilpo J?rvinen wrote:
> > +		pnob->event_q_pa = virt_to_phys(pnob->event_q);
> > +		pnob->event_q_pa = cpu_to_le64(pnob->event_q_pa);
> 
> ...First of all, points from using standard converters instead of 
> inventing your own :-).
> 
> But alas, it won't be accepted by sparse. You need to use appropriate 
> le/be8/16/32/64 types when dealing with endianesses and then make sparse 
> happy too by using conversion in proper places. 

And virt_to_phys is a big no-way.  The driver needs to use the proper
dma api helpers to deal with iommus and other non-trivial hardware.


  reply	other threads:[~2008-05-16 10:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-15  9:06 [PATCH 2/15] BE NIC driver - interrupt, ethtool, stack i/f functions Subbu Seetharaman
2008-05-15  9:02 ` [PATCH 1/15] BE NIC driver - header and initialization functions Subbu Seetharaman
2008-05-15 11:49   ` Ben Hutchings
2008-05-16  9:54   ` Ilpo Järvinen
2008-05-16 10:06     ` Christoph Hellwig [this message]
2008-05-15 12:14 ` [PATCH 2/15] BE NIC driver - interrupt, ethtool, stack i/f functions Ben Hutchings
2008-05-15 12:49 ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080516100642.GA18884@infradead.org \
    --to=hch@infradead.org \
    --cc=ilpo.jarvinen@helsinki.fi \
    --cc=netdev@vger.kernel.org \
    --cc=subbus@serverengines.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).