From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Tobias Diedrich <ranma+kernel@tdiedrich.de>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Ayaz Abdulla <aabdulla@nvidia.com>
Subject: Re: hibernate event order question
Date: Sun, 18 May 2008 12:45:13 +0200 [thread overview]
Message-ID: <200805181245.13899.rjw@sisk.pl> (raw)
In-Reply-To: <20080517232411.GA8792@yamamaya.is-a-geek.org>
On Sunday, 18 of May 2008, Tobias Diedrich wrote:
> Tobias Diedrich wrote:
> > > > Shouldn't there be a 'prepare for poweroff'-callback, which gets
> > > > called
> > > > before the system is powered off for real?
> > >
> > > Yes, it should and it's called in recent kernels.
> >
> > For what values of 'recent'?
> > I'm running 2.6.26-rc2 here. :)
> > How do I hook into this callback?
> > (suspend_late maybe? Going to try that one next...)
>
> Ok, this patch fixes the 'regression' introduced by the previous
> patch (at least for me ;)):
Well, what exactly do you do to hibernate the box?
> Index: linux-2.6.26-rc2.forcedwol/drivers/net/forcedeth.c
> ===================================================================
> --- linux-2.6.26-rc2.forcedwol.orig/drivers/net/forcedeth.c 2008-05-18 01:10:18.000000000 +0200
> +++ linux-2.6.26-rc2.forcedwol/drivers/net/forcedeth.c 2008-05-18 01:11:33.000000000 +0200
> @@ -5828,8 +5828,24 @@
> out:
> return rc;
> }
> +
> +static void nv_shutdown(struct pci_dev *pdev)
> +{
> + struct net_device *dev = pci_get_drvdata(pdev);
> + struct fe_priv *np = netdev_priv(dev);
> + u8 __iomem *base = get_hwbase(dev);
> +
> + if (netif_running(dev))
> + nv_close(dev);
> +
> + pci_enable_wake(pdev, PCI_D3hot, np->wolenabled);
> + pci_enable_wake(pdev, PCI_D3cold, np->wolenabled);
> + pci_disable_device(pdev);
> + pci_set_power_state(pdev, PCI_D3hot);
> +}
> #else
> #define nv_suspend NULL
> +#define nv_shutdown NULL
> #define nv_resume NULL
> #endif /* CONFIG_PM */
>
> @@ -6000,6 +6016,7 @@
> .remove = __devexit_p(nv_remove),
> .suspend = nv_suspend,
> .resume = nv_resume,
> + .shutdown = nv_shutdown,
> };
>
> static int __init init_nic(void)
>
next prev parent reply other threads:[~2008-05-18 10:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080517175046.GA9032@yamamaya.is-a-geek.org>
[not found] ` <200805172156.12686.rjw@sisk.pl>
2008-05-17 22:36 ` hibernate event order question Tobias Diedrich
2008-05-17 23:24 ` Tobias Diedrich
2008-05-18 10:45 ` Rafael J. Wysocki [this message]
2008-05-18 11:22 ` Tobias Diedrich
2008-05-18 11:32 ` Rafael J. Wysocki
2008-05-18 12:24 ` Tobias Diedrich
2008-05-18 12:29 ` Rafael J. Wysocki
2008-05-17 17:50 Tobias Diedrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805181245.13899.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=aabdulla@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ranma+kernel@tdiedrich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox