From: David Miller <davem@davemloft.net>
To: jchapman@katalix.com
Cc: netdev@vger.kernel.org, bc-info@styx.cabel.net
Subject: Re: [PATCH] L2TP: avoid skb truesize bug if headroom is increased
Date: Mon, 19 May 2008 14:10:38 -0700 (PDT) [thread overview]
Message-ID: <20080519.141038.267900372.davem@davemloft.net> (raw)
In-Reply-To: <200805192009.m4JK98DO003387@quickie.katalix.com>
From: James Chapman <jchapman@katalix.com>
Date: Mon, 19 May 2008 21:09:08 +0100
> A user reported seeing occasional bugs such as the following when
> using the L2TP driver.
>
> SKB BUG: Invalid truesize (272) len=72, sizeof(sk_buff)=208
>
> When L2TP adds its header in the transmit path, it might need to
> increase the headroom of the skb. In some cases, the increased
> headroom trips a kernel bug when the skb is freed because the skb has
> grown beyond its truesize value. The fix is to increase the truesize
> by the amount of headroom added, after orphaning the skb.
>
> While here, fix a misleading comment.
>
> Thanks to Iouri Kharon <bc-info@styx.cabel.net> for the initial
> report and testing the fix.
>
> Signed-off-by: James Chapman <jchapman@katalix.com>
Applied, thanks James.
Longer term I'll try to come up with a way to make it harder
to get this stuff wrong.
prev parent reply other threads:[~2008-05-19 21:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-19 20:09 [PATCH] L2TP: avoid skb truesize bug if headroom is increased James Chapman
2008-05-19 21:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080519.141038.267900372.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bc-info@styx.cabel.net \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).