* [PATCH net-2.6 1/4] [IPV6] ADDRCONF: Fix route lifetime setting in corner case.
@ 2008-05-15 9:17 YOSHIFUJI Hideaki / 吉藤英明
2008-05-19 23:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2008-05-15 9:17 UTC (permalink / raw)
To: davem; +Cc: yoshfuji, netdev
Because of arithmetic overflow avoidance, the actual lifetime setting
(vs the value given by RA) did not increase monotonically around
0x7fffffff/HZ.
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
---
net/ipv6/route.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 12bba08..98aa50c 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -475,7 +475,7 @@ int rt6_route_rcv(struct net_device *dev, u8 *opt, int len,
lifetime = ntohl(rinfo->lifetime);
if (lifetime == 0xffffffff) {
/* infinity */
- } else if (lifetime > 0x7fffffff/HZ) {
+ } else if (lifetime > 0x7fffffff/HZ - 1) {
/* Avoid arithmetic overflow */
lifetime = 0x7fffffff/HZ - 1;
}
--
1.4.4.4
--
YOSHIFUJI Hideaki @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG-FP : 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-2.6 1/4] [IPV6] ADDRCONF: Fix route lifetime setting in corner case.
2008-05-15 9:17 [PATCH net-2.6 1/4] [IPV6] ADDRCONF: Fix route lifetime setting in corner case YOSHIFUJI Hideaki / 吉藤英明
@ 2008-05-19 23:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-05-19 23:54 UTC (permalink / raw)
To: yoshfuji; +Cc: netdev
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org>
Date: Thu, 15 May 2008 18:17:55 +0900 (JST)
> Because of arithmetic overflow avoidance, the actual lifetime setting
> (vs the value given by RA) did not increase monotonically around
> 0x7fffffff/HZ.
>
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Patch applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-19 23:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-15 9:17 [PATCH net-2.6 1/4] [IPV6] ADDRCONF: Fix route lifetime setting in corner case YOSHIFUJI Hideaki / 吉藤英明
2008-05-19 23:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).