From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: dwmw2@infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH?] Fix call to ->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags()
Date: Tue, 20 May 2008 14:36:41 -0700 (PDT) [thread overview]
Message-ID: <20080520.143641.122144468.davem@davemloft.net> (raw)
In-Reply-To: <4832C864.8020605@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Tue, 20 May 2008 14:47:32 +0200
> David Woodhouse wrote:
> > Am I just being particularly dim today, or can the call to
> > dev->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags() never
> > happen?
> >
> > We've just set dev->flags = flags & IFF_MULTICAST, effectively. So the
> > condition '(dev->flags ^ flags) & IFF_MULTICAST' is _never_ going to be
> > true.
>
> Thanks for catching this, you're correct of course.
Applied and queued to -stable, thanks everyone!
prev parent reply other threads:[~2008-05-20 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 12:11 [PATCH?] Fix call to ->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags() David Woodhouse
2008-05-20 12:47 ` Patrick McHardy
2008-05-20 21:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520.143641.122144468.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).