From: David Miller <davem@davemloft.net>
To: harvey.harrison@gmail.com
Cc: crquan@gmail.com, herbert@gondor.apana.org.au,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from lib/hexdump.c instead
Date: Tue, 20 May 2008 15:45:51 -0700 (PDT) [thread overview]
Message-ID: <20080520.154551.54365414.davem@davemloft.net> (raw)
In-Reply-To: <1211323212.5915.220.camel@brick>
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Tue, 20 May 2008 15:40:12 -0700
> On Tue, 2008-05-20 at 15:36 -0700, David Miller wrote:
> > From: Denis Cheng <crquan@gmail.com>
> > Date: Mon, 19 May 2008 02:37:44 +0800
> >
> > > Here the local hexbuf is a duplicate of global const char hex_asc from
> > > lib/hexdump.c, except the hex letters' cases:
> > >
> > > const char hexbuf[] = "0123456789ABCDEF";
> > >
> > > const char hex_asc[] = "0123456789abcdef";
> > >
> > > and here to print HW addresses, the hex cases are not significant.
> > >
> > > Signed-off-by: Denis Cheng <crquan@gmail.com>
> >
> > Applied, thanks.
>
> You may want to use the hex_asc_hi, hex_asc_lo helpers to do the
> mask/shifts for you.
Good idea, I'll revert, Denis can you generate a new patch?
Thanks.
next prev parent reply other threads:[~2008-05-20 22:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-18 18:37 [PATCH] net/ipv4/arp.c: Use the exported hex_asc from lib/hexdump.c instead Denis Cheng
2008-05-20 22:36 ` David Miller
2008-05-20 22:40 ` Harvey Harrison
2008-05-20 22:45 ` David Miller [this message]
2008-05-21 2:27 ` rae l
2008-05-22 0:35 ` David Miller
2008-05-22 0:37 ` Harvey Harrison
2008-05-22 1:04 ` rae l
2008-05-20 22:41 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520.154551.54365414.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=crquan@gmail.com \
--cc=harvey.harrison@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).