From: Stephen Hemminger <shemminger@vyatta.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: David Miller <davem@davemloft.net>,
greg@kroah.com, fubar@us.ibm.com, netdev@vger.kernel.org,
bonding-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver core: Suppress sysfs warnings for device_rename().
Date: Tue, 20 May 2008 14:45:08 -0700 [thread overview]
Message-ID: <20080520144508.410ed857@extreme> (raw)
In-Reply-To: <20080520125913.777ed67d@gondolin.boeblingen.de.ibm.com>
On Tue, 20 May 2008 12:59:13 +0200
Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
> OK, here is an actually-compiled patch with proper description and
> s-o-b. Comments?
>
> -----
>
> driver core: Suppress sysfs warnings for device_rename().
>
> Renaming network devices to an already existing name is not
> something we want sysfs to print a scary warning for, since the
> callers can deal with this correctly. So let's introduce
> sysfs_create_link_nowarn() which gets rid of the common warning.
>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>
This is still getting to be overkill. I prefer that the warnings
always are removed.
next prev parent reply other threads:[~2008-05-20 21:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 0:03 [PATCH] net: Avoid problems with bonding and device rename Stephen Hemminger
2008-05-15 0:07 ` David Miller
2008-05-15 1:15 ` [PATCH 1/3] net: handle errors from device_rename Stephen Hemminger
2008-05-15 5:33 ` David Miller
2008-05-15 8:41 ` Wang Chen
2008-05-15 20:09 ` Stephen Hemminger
[not found] ` <20080514181257.74fbb5aa@extreme>
2008-05-15 1:15 ` [PATCH 3/3] bonding: handle case of device named bonding_master Stephen Hemminger
2008-05-15 5:35 ` David Miller
2008-05-15 1:16 ` [PATCH 2/3] sysfs: remove error messages for -EEXIST case Stephen Hemminger
2008-05-15 1:26 ` David Miller
2008-05-15 3:14 ` Greg KH
2008-05-15 5:26 ` David Miller
2008-05-15 5:34 ` David Miller
2008-05-15 7:52 ` Cornelia Huck
2008-05-15 8:01 ` David Miller
2008-05-15 9:31 ` Cornelia Huck
2008-05-15 10:00 ` David Miller
2008-05-15 10:06 ` Cornelia Huck
2008-05-20 10:59 ` [PATCH] driver core: Suppress sysfs warnings for device_rename() Cornelia Huck
2008-05-20 21:45 ` Stephen Hemminger [this message]
2008-05-20 22:52 ` Greg KH
2008-05-20 22:52 ` Greg KH
2008-05-21 8:05 ` Cornelia Huck
2008-06-10 9:09 ` Cornelia Huck
2008-06-10 15:30 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520144508.410ed857@extreme \
--to=shemminger@vyatta.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=cornelia.huck@de.ibm.com \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).