From: Ben Hutchings <bhutchings@solarflare.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Peter Warasin <peter@endian.com>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [RFC, VLAN]: Propagate selected feature bits to VLAN devices
Date: Tue, 20 May 2008 15:48:23 +0100 [thread overview]
Message-ID: <20080520144822.GR28241@solarflare.com> (raw)
In-Reply-To: <4832E223.7020206@trash.net>
Patrick McHardy wrote:
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index b11e6e1..3be4559 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -514,10 +514,11 @@ struct net_device
> #define NETIF_F_NETNS_LOCAL 8192 /* Does not change network namespaces */
> #define NETIF_F_MULTI_QUEUE 16384 /* Has multiple TX/RX queues */
> #define NETIF_F_LRO 32768 /* large receive offload */
> +#define NETIF_F_VLAN_TSO 65536 /* Supports TSO for VLANs */
>
> /* Segmentation offload features */
> -#define NETIF_F_GSO_SHIFT 16
> -#define NETIF_F_GSO_MASK 0xffff0000
> +#define NETIF_F_GSO_SHIFT 20
> +#define NETIF_F_GSO_MASK 0xfff00000
I really don't think it's a good idea to move around existing flags. How
about stealing some of the unused high-order bits of NETIF_F_GSO_MASK
instead?
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
next prev parent reply other threads:[~2008-05-20 14:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 14:37 [RFC, VLAN]: Propagate selected feature bits to VLAN devices Patrick McHardy
2008-05-20 14:38 ` Patrick McHardy
2008-05-20 14:48 ` Ben Hutchings [this message]
2008-05-20 14:51 ` Patrick McHardy
2008-05-20 15:46 ` Ben Greear
2008-05-20 16:20 ` Ben Hutchings
2008-05-20 16:27 ` Patrick McHardy
2008-05-20 16:28 ` Ben Greear
2008-05-20 17:22 ` Waskiewicz Jr, Peter P
2008-05-20 17:23 ` Patrick McHardy
2008-05-20 18:05 ` Ben Hutchings
2008-05-20 18:31 ` Patrick McHardy
2008-05-20 19:58 ` Waskiewicz Jr, Peter P
2008-05-20 23:59 ` Patrick McHardy
2008-05-20 21:55 ` David Miller
2008-05-20 23:58 ` Patrick McHardy
2008-05-21 15:49 ` Herbert Xu
2008-05-21 16:28 ` Patrick McHardy
2008-05-21 23:39 ` Herbert Xu
2008-05-22 17:47 ` Waskiewicz Jr, Peter P
2008-05-22 18:03 ` Patrick McHardy
2008-05-22 18:18 ` Waskiewicz Jr, Peter P
2008-05-22 18:25 ` Patrick McHardy
2008-05-22 18:57 ` Waskiewicz Jr, Peter P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520144822.GR28241@solarflare.com \
--to=bhutchings@solarflare.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=peter@endian.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).