From: Pavel Machek <pavel@suse.cz>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: akpm@linux-foundation.org, hidave.darkstar@gmail.com,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [patch 2/3] hci_usb: remove code obfuscation
Date: Tue, 20 May 2008 17:24:06 +0200 [thread overview]
Message-ID: <20080520152405.GC2067@elf.ucw.cz> (raw)
In-Reply-To: <15B7927A-D74F-450D-A6A4-0204FAD455F6@holtmann.org>
Hi!
>> There needs to be some load on the usb. I use
>> rsync-over-bt-over-gprs/umts.
>
> you told me before and I believe you. This driver is not in its best shape.
> Weird thing is that I never got it re-produced. If you find the real cause.
> That would be great.
The cause seems to be hci_usb_close() racing with the USB core and
completion handlers...
>>>> It could be easily fixed by just not freeing the urbs during
>>>> disconnect (introducing very very slow memory leak). Would that be
>>>> acceptable?
>>>
>>> I don't think so.
>>>
>>> Have you ever tried btusb driver? That code is a lot cleaner and it uses
>>> USB anchors for the queued URBs (no home grown broken URB queues).
>>
>> I wish I knew about this one earlier. Yes, it seems to work for me.
>
> Does this mean you are not fixing hci_usb anymore ;)
I'm not sure what's next, as hci_usb is still in opensuse11...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-05-20 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 20:46 [patch 2/3] hci_usb: remove code obfuscation akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b
2008-04-18 21:07 ` Marcel Holtmann
[not found] ` <9BEB490E-DE8A-4018-9696-E5074CC638AC-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2008-04-18 22:34 ` Pavel Machek
2008-04-19 1:28 ` Marcel Holtmann
2008-04-19 16:14 ` Pavel Machek
2008-04-19 17:43 ` Marcel Holtmann
2008-05-20 15:24 ` Pavel Machek [this message]
[not found] ` <20080520152405.GC2067-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2008-05-20 17:26 ` Marcel Holtmann
2008-05-22 22:45 ` Pavel Machek
[not found] ` <200804182046.m3IKks86014628-AB4EexQrvXRQetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2008-04-20 1:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520152405.GC2067@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hidave.darkstar@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).