From: David Miller <davem@davemloft.net>
To: randy.dunlap@oracle.com
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, akpm@linux-foundation.org
Subject: Re: [PATCH] netfilter: conntrack_helper needs to include rculist.h
Date: Wed, 21 May 2008 14:45:50 -0700 (PDT) [thread overview]
Message-ID: <20080521.144550.151762863.davem@davemloft.net> (raw)
In-Reply-To: <20080521142139.f0bc5698.randy.dunlap@oracle.com>
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Wed, 21 May 2008 14:21:39 -0700
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> nf_conntrack_helper users rcu hlist functions so it needs to #include
> rculist.h.
>
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: implicit declaration of function 'hlist_for_each_entry_rcu'
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: 'hnode' undeclared (first use in this function)
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: (Each undeclared identifier is reported only once
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: for each function it appears in.)
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: expected ';' before '{' token
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:50: warning: unused variable 'mask'
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:74: error: 'hnode' undeclared (first use in this function)
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:74: error: expected ';' before '{' token
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:117: error: implicit declaration of function 'hlist_add_head_rcu'
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:133: error: implicit declaration of function 'hlist_del_rcu'
> filter/nf_conntrack_helper.o] Error 1
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
This needs to go in via whatever tree adds the linux/rculist.h header file,
which isn't net-next-2.6 as far as I can tell. :-)
next prev parent reply other threads:[~2008-05-21 21:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 21:21 [PATCH] netfilter: conntrack_helper needs to include rculist.h Randy Dunlap
2008-05-21 21:45 ` David Miller [this message]
2008-05-21 21:55 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521.144550.151762863.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).