* [PATCH] netfilter: conntrack_helper needs to include rculist.h
@ 2008-05-21 21:21 Randy Dunlap
2008-05-21 21:45 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2008-05-21 21:21 UTC (permalink / raw)
To: netdev; +Cc: davem, netfilter-devel, coreteam, akpm
From: Randy Dunlap <randy.dunlap@oracle.com>
nf_conntrack_helper users rcu hlist functions so it needs to #include
rculist.h.
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: implicit declaration of function 'hlist_for_each_entry_rcu'
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: 'hnode' undeclared (first use in this function)
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: (Each undeclared identifier is reported only once
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: for each function it appears in.)
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: expected ';' before '{' token
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:50: warning: unused variable 'mask'
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:74: error: 'hnode' undeclared (first use in this function)
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:74: error: expected ';' before '{' token
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:117: error: implicit declaration of function 'hlist_add_head_rcu'
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:133: error: implicit declaration of function 'hlist_del_rcu'
filter/nf_conntrack_helper.o] Error 1
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
net/netfilter/nf_conntrack_helper.c | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20080521.orig/net/netfilter/nf_conntrack_helper.c
+++ linux-next-20080521/net/netfilter/nf_conntrack_helper.c
@@ -10,6 +10,7 @@
*/
#include <linux/types.h>
+#include <linux/rculist.h>
#include <linux/netfilter.h>
#include <linux/module.h>
#include <linux/skbuff.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] netfilter: conntrack_helper needs to include rculist.h
2008-05-21 21:21 [PATCH] netfilter: conntrack_helper needs to include rculist.h Randy Dunlap
@ 2008-05-21 21:45 ` David Miller
2008-05-21 21:55 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2008-05-21 21:45 UTC (permalink / raw)
To: randy.dunlap; +Cc: netdev, netfilter-devel, coreteam, akpm
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Wed, 21 May 2008 14:21:39 -0700
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> nf_conntrack_helper users rcu hlist functions so it needs to #include
> rculist.h.
>
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: implicit declaration of function 'hlist_for_each_entry_rcu'
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: 'hnode' undeclared (first use in this function)
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: (Each undeclared identifier is reported only once
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: for each function it appears in.)
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: expected ';' before '{' token
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:50: warning: unused variable 'mask'
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:74: error: 'hnode' undeclared (first use in this function)
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:74: error: expected ';' before '{' token
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:117: error: implicit declaration of function 'hlist_add_head_rcu'
> linux-next-20080521/net/netfilter/nf_conntrack_helper.c:133: error: implicit declaration of function 'hlist_del_rcu'
> filter/nf_conntrack_helper.o] Error 1
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
This needs to go in via whatever tree adds the linux/rculist.h header file,
which isn't net-next-2.6 as far as I can tell. :-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] netfilter: conntrack_helper needs to include rculist.h
2008-05-21 21:45 ` David Miller
@ 2008-05-21 21:55 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2008-05-21 21:55 UTC (permalink / raw)
To: David Miller, mingo, lkml; +Cc: netdev, akpm, netfilter-devel, coreteam
On Wed, 21 May 2008 14:45:50 -0700 (PDT) David Miller wrote:
> This needs to go in via whatever tree adds the linux/rculist.h header file,
> which isn't net-next-2.6 as far as I can tell. :-)
Sure, makes sense.
Looks like it's some sched/auto-sched tree/branch if I'm reading
correctly.
Ingo, is there a sched tree that add rculist.h file?
If so, one of its users needs to #include it. Patch below.
---
From: Randy Dunlap <randy.dunlap@oracle.com>
nf_conntrack_helper users rcu hlist functions so it needs to #include
rculist.h.
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: implicit declaration of function 'hlist_for_each_entry_rcu'
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: 'hnode' undeclared (first use in this function)
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: (Each undeclared identifier is reported only once
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: for each function it appears in.)
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: expected ';' before '{' token
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:50: warning: unused variable 'mask'
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:74: error: 'hnode' undeclared (first use in this function)
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:74: error: expected ';' before '{' token
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:117: error: implicit declaration of function 'hlist_add_head_rcu'
linux-next-20080521/net/netfilter/nf_conntrack_helper.c:133: error: implicit declaration of function 'hlist_del_rcu'
filter/nf_conntrack_helper.o] Error 1
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
net/netfilter/nf_conntrack_helper.c | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20080521.orig/net/netfilter/nf_conntrack_helper.c
+++ linux-next-20080521/net/netfilter/nf_conntrack_helper.c
@@ -10,6 +10,7 @@
*/
#include <linux/types.h>
+#include <linux/rculist.h>
#include <linux/netfilter.h>
#include <linux/module.h>
#include <linux/skbuff.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-21 21:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-21 21:21 [PATCH] netfilter: conntrack_helper needs to include rculist.h Randy Dunlap
2008-05-21 21:45 ` David Miller
2008-05-21 21:55 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).