From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: [PATCH] netfilter: conntrack_helper needs to include rculist.h Date: Wed, 21 May 2008 14:55:32 -0700 Message-ID: <20080521145532.8e779533.randy.dunlap@oracle.com> References: <20080521142139.f0bc5698.randy.dunlap@oracle.com> <20080521.144550.151762863.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, akpm@linux-foundation.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org To: David Miller , mingo , lkml Return-path: Received: from rgminet01.oracle.com ([148.87.113.118]:47239 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754480AbYEUV4X (ORCPT ); Wed, 21 May 2008 17:56:23 -0400 In-Reply-To: <20080521.144550.151762863.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 21 May 2008 14:45:50 -0700 (PDT) David Miller wrote: > This needs to go in via whatever tree adds the linux/rculist.h header file, > which isn't net-next-2.6 as far as I can tell. :-) Sure, makes sense. Looks like it's some sched/auto-sched tree/branch if I'm reading correctly. Ingo, is there a sched tree that add rculist.h file? If so, one of its users needs to #include it. Patch below. --- From: Randy Dunlap nf_conntrack_helper users rcu hlist functions so it needs to #include rculist.h. linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: implicit declaration of function 'hlist_for_each_entry_rcu' linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: 'hnode' undeclared (first use in this function) linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: (Each undeclared identifier is reported only once linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: for each function it appears in.) linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: expected ';' before '{' token linux-next-20080521/net/netfilter/nf_conntrack_helper.c:50: warning: unused variable 'mask' linux-next-20080521/net/netfilter/nf_conntrack_helper.c:74: error: 'hnode' undeclared (first use in this function) linux-next-20080521/net/netfilter/nf_conntrack_helper.c:74: error: expected ';' before '{' token linux-next-20080521/net/netfilter/nf_conntrack_helper.c:117: error: implicit declaration of function 'hlist_add_head_rcu' linux-next-20080521/net/netfilter/nf_conntrack_helper.c:133: error: implicit declaration of function 'hlist_del_rcu' filter/nf_conntrack_helper.o] Error 1 Signed-off-by: Randy Dunlap --- net/netfilter/nf_conntrack_helper.c | 1 + 1 file changed, 1 insertion(+) --- linux-next-20080521.orig/net/netfilter/nf_conntrack_helper.c +++ linux-next-20080521/net/netfilter/nf_conntrack_helper.c @@ -10,6 +10,7 @@ */ #include +#include #include #include #include