netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: tgraf@suug.ch, shemminger@vyatta.com, davej@codemonkey.org.uk,
	netdev@vger.kernel.org
Subject: Re: [NETLINK]: Fix nla_parse_nested_compat() to call nla_parse() directly
Date: Thu, 22 May 2008 10:49:13 -0700 (PDT)	[thread overview]
Message-ID: <20080522.104913.231161238.davem@davemloft.net> (raw)
In-Reply-To: <48356AE3.7050700@trash.net>

From: Patrick McHardy <kaber@trash.net>
Date: Thu, 22 May 2008 14:45:23 +0200

> Thomas Graf wrote:
> > The purpose of nla_parse_nested_compat() is to parse attributes
> > which contain a struct followed by a stream of nested attributes.
> > So far, it called nla_parse_nested() to parse the stream of
> > nested attributes which was wrong, as nla_parse_nested() expects
> > a container attribute as data which holds the attribute stream.
> > It needs to call nla_parse() directly while pointing at the
> > next possible alignment point after the struct in the beginning
> > of the attribute.
> >
> > With this patch, I can no longer reproduce the reported leftover
> > warnings.
> >
> > Signed-off-by: Thomas Graf <tgraf@suug.ch>
> 
> Looks good to me, thanks for fixing this Thomas.

Patch applied, thanks everyone.

  reply	other threads:[~2008-05-22 17:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21 21:45 Fwd: [Bug 447812] New: Netlink messages from "tc" to sch_netem module are not interpreted correctly Dave Jones
2008-05-21 22:10 ` Stephen Hemminger
2008-05-22  0:21   ` Thomas Graf
2008-05-22  0:57     ` Rick Jones
2008-05-22 11:18       ` Thomas Graf
2008-05-22 16:32         ` Rick Jones
2008-05-22 11:37     ` [NETLINK]: Fix nla_parse_nested_compat() to call nla_parse() directly Thomas Graf
2008-05-22 12:45       ` Patrick McHardy
2008-05-22 17:49         ` David Miller [this message]
2008-05-22 18:02           ` Stephen Hemminger
2008-05-22 18:11             ` David Miller
2008-05-21 22:16 ` Fwd: [Bug 447812] New: Netlink messages from "tc" to sch_netem module are not interpreted correctly Rick Jones
2008-05-21 22:36   ` Rick Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080522.104913.231161238.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=davej@codemonkey.org.uk \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).