netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: johnpol@2ka.mipt.ru
Cc: kchudgar@amcc.com, kchudgar.linux@gmail.com, netdev@vger.kernel.org
Subject: Re: Single packet receiving in multiple ring buffers
Date: Thu, 22 May 2008 11:57:55 -0700 (PDT)	[thread overview]
Message-ID: <20080522.115755.202204829.davem@davemloft.net> (raw)
In-Reply-To: <20080522184906.GA32582@2ka.mipt.ru>

From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Date: Thu, 22 May 2008 22:49:07 +0400

> You have to copy part of the data (up to and including transport headers)
> into skb->data.

You don't necessarily have to.  The input paths of the networking
stack will pull into the skb->data, as needed, using
pskb_may_pull() calls.

I did some tests with the NIU driver on receive, and to be
honest there was nearly zero performance gain from pre-copying
into skb->data from the paged SKB area preemptively before
passing the packet in via netif_receive_skb().

  reply	other threads:[~2008-05-22 18:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-22  1:35 Single packet receiving in multiple ring buffers Keyur Chudgar
2008-05-22  6:40 ` Evgeniy Polyakov
     [not found]   ` <31256957387BB54C8B9AFE88AA5C0564044A1834@SDCEXCHANGE01.ad.amcc.com>
2008-05-22 18:14     ` Evgeniy Polyakov
     [not found]       ` <31256957387BB54C8B9AFE88AA5C0564044A1846@SDCEXCHANGE01.ad.amcc.com>
2008-05-22 18:49         ` Evgeniy Polyakov
2008-05-22 18:57           ` David Miller [this message]
     [not found]             ` <31256957387BB54C8B9AFE88AA5C0564044A1869@SDCEXCHANGE01.ad.amcc.com>
2008-05-23  7:09               ` David Miller
2008-05-23 12:00             ` Evgeniy Polyakov
     [not found]               ` <31256957387BB54C8B9AFE88AA5C0564044A1951@SDCEXCHANGE01.ad.amcc.com>
2008-05-25 13:00                 ` Evgeniy Polyakov
2008-05-25 13:04                   ` David Miller
2008-05-25 13:31                     ` Evgeniy Polyakov
     [not found]                   ` <31256957387BB54C8B9AFE88AA5C0564044A1B23@SDCEXCHANGE01.ad.amcc.com>
2008-05-27 17:41                     ` Evgeniy Polyakov
     [not found]                   ` <31256957387BB54C8B9AFE88AA5C0564044A1DC1@SDCEXCHANGE01.ad.amcc.com>
2008-05-29 14:45                     ` Evgeniy Polyakov
     [not found]                       ` <31256957387BB54C8B9AFE88AA5C0564044A1DD0@SDCEXCHANGE01.ad.amcc.com>
2008-05-29 15:35                         ` Evgeniy Polyakov
     [not found]                           ` <31256957387BB54C8B9AFE88AA5C0564044A1DF1@SDCEXCHANGE01.ad.amcc.com>
2008-05-29 16:41                             ` Evgeniy Polyakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080522.115755.202204829.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=johnpol@2ka.mipt.ru \
    --cc=kchudgar.linux@gmail.com \
    --cc=kchudgar@amcc.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).