From: Christoph Hellwig <hch@infradead.org>
To: Michael Chan <mchan@broadcom.com>
Cc: davem@davemloft.net, michaelc@cs.wisc.edu, anilgv@broadcom.com,
netdev@vger.kernel.org, linux-scsi@vger.kernel.org,
open-iscsi@googlegroups.com
Subject: Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver.
Date: Thu, 22 May 2008 17:15:59 -0400 [thread overview]
Message-ID: <20080522211559.GA29851@infradead.org> (raw)
In-Reply-To: <1211418386-18203-4-git-send-email-mchan@broadcom.com>
> +struct bnx2i_async_msg {
> +#if defined(__BIG_ENDIAN)
> + u8 op_code;
> + u8 reserved1;
> + u16 reserved0;
> +#elif defined(__LITTLE_ENDIAN)
> + u16 reserved0;
> + u8 reserved1;
> + u8 op_code;
> +#endif
> + u32 reserved2;
> + u32 exp_cmd_sn;
> + u32 max_cmd_sn;
> + u32 reserved3[2];
Please don't do the ifdef big endian mess. Just read the whole
32bit word and do mask and shift operations to extract the actual value.
next prev parent reply other threads:[~2008-05-22 21:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 1:06 [PATCH 0/3] bnx2: Add iSCSI support Michael Chan
[not found] ` <1211418386-18203-1-git-send-email-mchan-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2008-05-22 1:06 ` [PATCH 1/3] bnx2: Add support for CNIC driver Michael Chan
2008-05-22 6:45 ` Paul E. McKenney
[not found] ` <20080522064541.GA11933-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2008-05-22 19:23 ` Michael Chan
2008-05-23 3:45 ` Paul E. McKenney
[not found] ` <20080523034522.GA8612-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2008-05-23 4:52 ` Michael Chan
2008-05-23 5:32 ` Paul E. McKenney
[not found] ` <1211418386-18203-2-git-send-email-mchan-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2008-05-22 15:18 ` Konrad Rzeszutek
2008-05-22 1:06 ` [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver Michael Chan
[not found] ` <1211418386-18203-4-git-send-email-mchan-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2008-05-22 15:15 ` Konrad Rzeszutek
2008-05-22 15:52 ` Ben Hutchings
2008-05-22 19:06 ` Anil Veerabhadrappa
2008-05-22 21:15 ` Christoph Hellwig [this message]
2008-05-22 22:59 ` Michael Chan
2008-05-23 20:23 ` Roland Dreier
2008-05-23 21:42 ` Anil Veerabhadrappa
2008-05-27 14:38 ` Roland Dreier
2008-05-27 19:17 ` Michael Chan
2008-05-27 18:21 ` Roland Dreier
2008-05-27 19:52 ` David Miller
2008-05-28 0:48 ` Michael Chan
2008-05-28 3:39 ` Jeff Garzik
2008-05-28 8:47 ` Hannes Reinecke
2008-05-22 1:06 ` [PATCH 2/3] cnic: Add CNIC driver Michael Chan
2008-05-22 7:44 ` Paul E. McKenney
2008-05-22 19:46 ` Michael Chan
2008-05-23 3:47 ` Paul E. McKenney
2008-05-23 20:09 ` Roland Dreier
2008-05-23 20:14 ` Roland Dreier
2008-05-24 0:42 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080522211559.GA29851@infradead.org \
--to=hch@infradead.org \
--cc=anilgv@broadcom.com \
--cc=davem@davemloft.net \
--cc=linux-scsi@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=michaelc@cs.wisc.edu \
--cc=netdev@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).