Re: [patch 2/3] hci_usb: remove code obfuscation

[Pavel Machek <pavel@suse.cz>]

Hi!

>>>>>> It could be easily fixed by just not freeing the urbs during
>>>>>> disconnect (introducing very very slow memory leak). Would that be
>>>>>> acceptable?
>>>>>
>>>>> I don't think so.
>>>>>
>>>>> Have you ever tried btusb driver? That code is a lot cleaner and it 
>>>>> uses
>>>>> USB anchors for the queued URBs (no home grown broken URB queues).
>>>>
>>>> I wish I knew about  this one earlier. Yes, it seems to work for me.
>>>
>>> Does this mean you are not fixing hci_usb anymore ;)
>>
>> I'm not sure what's next, as hci_usb is still in opensuse11...
>
> the goal should be improve btusb. Especially add all the needed quirks from 
> the hci_usb driver to it. I have a patch for it, but I need to reverse the 
> HCI_RESET logic.

Could I get a copy of that patch?

> However if you have hci_usb patches, send them, I will review them and 
> David will happily apply them I guess.

No, I given up. I was not able to fix close vs. finishing urbs race
in a reliable way :-(.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html