netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marin Mitov <mitov@issp.bas.bg>
To: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org
Subject: pci_set_consistent_dma_mask() question
Date: Sun, 25 May 2008 08:43:47 +0300	[thread overview]
Message-ID: <200805250843.47179.mitov@issp.bas.bg> (raw)

Hi all,

In the file: Documentation/DMA-mapping.txt is written:

pci_set_consistent_dma_mask() will always be able to set the same or a
smaller mask as pci_set_dma_mask(). However for the rare case that a
device driver only uses consistent allocations, one would have to
check the return value from pci_set_consistent_dma_mask().

grep-ing drivers/net/* shows that in many drivers 
the return value of pci_set_consistent_dma_mask() is checked
in the path where pci_set_dma_mask() was already successfull.
Sure, this is during driver's initiallysation, so it is not time critical.

My question: Is it worth to remove the unnecessary checks?
I could prepare patches if you find it worthfull.

Best regards.

Marin Mitov

             reply	other threads:[~2008-05-25  5:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-25  5:43 Marin Mitov [this message]
2008-05-25 18:59 ` pci_set_consistent_dma_mask() question Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805250843.47179.mitov@issp.bas.bg \
    --to=mitov@issp.bas.bg \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).