From: David Miller <davem@davemloft.net>
To: gerrit@erg.abdn.ac.uk
Cc: dccp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 3/7] [CCID-3]: Remove ccid3hc{tx,rx}_ prefixes
Date: Tue, 27 May 2008 06:26:12 -0700 (PDT) [thread overview]
Message-ID: <20080527.062612.59188315.davem@davemloft.net> (raw)
In-Reply-To: <1211877167-10995-4-git-send-email-gerrit@erg.abdn.ac.uk>
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Tue, 27 May 2008 09:32:43 +0100
> This patch does the same for CCID-3 as the previous patch for CCID-2:
>
> s#ccid3hctx_##g;
> s#ccid3hcrx_##g;
>
> plus manual editing to retain consistency.
>
> Please note: expanded the fields of the `struct tfrc_tx_info' in the hc_tx_sock,
> since using short #define identifiers is not a good idea. The only place where
> this embedded struct was used is ccid3_hc_tx_getsockopt().
>
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
My same comments for CCID-2 apply here, don't do this, we use
the member name prefixes to make the code easier to search
precisely.
next prev parent reply other threads:[~2008-05-27 13:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <dccp_bug_fixes_and_format_updates>
2008-05-27 8:32 ` [DCCP] [Patch 0/7]: Bug fixes and format updates Gerrit Renker
2008-05-27 8:32 ` [PATCH 1/7] [DCCP]: Fix to handle short sequence numbers packet correctly Gerrit Renker
2008-05-27 8:32 ` [PATCH 2/7] [CCID-2]: Remove ccid2hc{tx,rx}_ prefixes Gerrit Renker
2008-05-27 8:32 ` [PATCH 3/7] [CCID-3]: Remove ccid3hc{tx,rx}_ prefixes Gerrit Renker
2008-05-27 8:32 ` [PATCH 4/7] [CCID-3]: Fix "t_ipi explosion" bug Gerrit Renker
2008-05-27 8:32 ` [PATCH 5/7] [CCID-3]: Remove ugly RTT-sampling history lookup Gerrit Renker
2008-05-27 8:32 ` [PATCH 6/7] [CCID-2/3]: Fix sparse warnings Gerrit Renker
2008-05-27 8:32 ` [PATCH 7/7] [TCP][DCCP]: Consolidate duplicate code which does RFC3390 conversion Gerrit Renker
2008-05-27 13:37 ` David Miller
2008-05-28 6:24 ` [Patch v2 1/1] [tcp/dccp]: " Gerrit Renker
2008-05-31 13:49 ` [Patch v3 " Gerrit Renker
2008-05-27 13:37 ` [PATCH 6/7] [CCID-2/3]: Fix sparse warnings David Miller
2008-05-27 13:36 ` [PATCH 5/7] [CCID-3]: Remove ugly RTT-sampling history lookup David Miller
2008-05-27 13:35 ` [PATCH 4/7] [CCID-3]: Fix "t_ipi explosion" bug David Miller
2008-05-27 14:16 ` Gerrit Renker
2008-05-27 13:26 ` David Miller [this message]
2008-05-27 13:25 ` [PATCH 2/7] [CCID-2]: Remove ccid2hc{tx,rx}_ prefixes David Miller
2008-05-27 14:07 ` Gerrit Renker
2008-05-27 19:31 ` David Miller
2008-05-27 13:22 ` [PATCH 1/7] [DCCP]: Fix to handle short sequence numbers packet correctly David Miller
2008-05-28 6:12 ` [DCCP] [Patch 0/7]: Bug fixes and format updates Gerrit Renker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080527.062612.59188315.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=gerrit@erg.abdn.ac.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).