* [PATCH -next] cxgb3: fix build error when INET=n
@ 2008-05-30 17:29 Randy Dunlap
2008-05-30 21:57 ` Divy Le Ray
2008-05-31 2:19 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2008-05-30 17:29 UTC (permalink / raw)
To: netdev, divy; +Cc: jgarzik, linux-next, akpm
From: Randy Dunlap <randy.dunlap@oracle.com>
cxgb3 uses lro_* functions and selects INET_LRO, but this doesn't help unless
INET is already enabled, so make the driver depend on INET also.
sge.c:(.text+0x9f09a): undefined reference to `lro_flush_all'
sge.c:(.text+0x9f62f): undefined reference to `lro_receive_skb'
sge.c:(.text+0x9f8a3): undefined reference to `lro_receive_frags'
sge.c:(.text+0x9fbe0): undefined reference to `lro_vlan_hwaccel_receive_skb'
sge.c:(.text+0x9ffcd): undefined reference to `lro_vlan_hwaccel_receive_frags'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/net/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20080530.orig/drivers/net/Kconfig
+++ linux-next-20080530/drivers/net/Kconfig
@@ -2407,7 +2407,7 @@ config CHELSIO_T1_NAPI
config CHELSIO_T3
tristate "Chelsio Communications T3 10Gb Ethernet support"
- depends on PCI
+ depends on PCI && INET
select FW_LOADER
select INET_LRO
help
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] cxgb3: fix build error when INET=n
2008-05-30 17:29 [PATCH -next] cxgb3: fix build error when INET=n Randy Dunlap
@ 2008-05-30 21:57 ` Divy Le Ray
2008-05-31 2:19 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Divy Le Ray @ 2008-05-30 21:57 UTC (permalink / raw)
To: Randy Dunlap; +Cc: netdev, jgarzik, linux-next, akpm
Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> cxgb3 uses lro_* functions and selects INET_LRO, but this doesn't help unless
> INET is already enabled, so make the driver depend on INET also.
>
> sge.c:(.text+0x9f09a): undefined reference to `lro_flush_all'
> sge.c:(.text+0x9f62f): undefined reference to `lro_receive_skb'
> sge.c:(.text+0x9f8a3): undefined reference to `lro_receive_frags'
> sge.c:(.text+0x9fbe0): undefined reference to `lro_vlan_hwaccel_receive_skb'
> sge.c:(.text+0x9ffcd): undefined reference to `lro_vlan_hwaccel_receive_frags'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>
Acked-by: Divy Le Ray <divy@chelsio.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] cxgb3: fix build error when INET=n
2008-05-30 17:29 [PATCH -next] cxgb3: fix build error when INET=n Randy Dunlap
2008-05-30 21:57 ` Divy Le Ray
@ 2008-05-31 2:19 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-05-31 2:19 UTC (permalink / raw)
To: Randy Dunlap; +Cc: netdev, divy, linux-next, akpm
Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> cxgb3 uses lro_* functions and selects INET_LRO, but this doesn't help unless
> INET is already enabled, so make the driver depend on INET also.
>
> sge.c:(.text+0x9f09a): undefined reference to `lro_flush_all'
> sge.c:(.text+0x9f62f): undefined reference to `lro_receive_skb'
> sge.c:(.text+0x9f8a3): undefined reference to `lro_receive_frags'
> sge.c:(.text+0x9fbe0): undefined reference to `lro_vlan_hwaccel_receive_skb'
> sge.c:(.text+0x9ffcd): undefined reference to `lro_vlan_hwaccel_receive_frags'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/net/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20080530.orig/drivers/net/Kconfig
> +++ linux-next-20080530/drivers/net/Kconfig
> @@ -2407,7 +2407,7 @@ config CHELSIO_T1_NAPI
>
> config CHELSIO_T3
> tristate "Chelsio Communications T3 10Gb Ethernet support"
> - depends on PCI
> + depends on PCI && INET
> select FW_LOADER
> select INET_LRO
> help
> --
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-31 2:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-30 17:29 [PATCH -next] cxgb3: fix build error when INET=n Randy Dunlap
2008-05-30 21:57 ` Divy Le Ray
2008-05-31 2:19 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).