From: David Miller <davem@davemloft.net>
To: jmorris@namei.org
Cc: agl@imperialviolet.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Fix corrupt TCP packets when options space overflows with MD5SIG enabled
Date: Sun, 01 Jun 2008 23:56:49 -0700 (PDT) [thread overview]
Message-ID: <20080601.235649.109450540.davem@davemloft.net> (raw)
In-Reply-To: <Xine.LNX.4.64.0806020938240.8594@us.intercode.com.au>
From: James Morris <jmorris@namei.org>
Date: Mon, 2 Jun 2008 09:40:15 +1000 (EST)
> On Sat, 31 May 2008, Adam Langley wrote:
>
> > When MD5 signatures are turned on we can end up with syntactically invalid
> > packets with a header length < 20 bytes. This is because tcp_header_size
> > overflows with 12 bytes of timestamp, 20 bytes of signature and > 8 bytes of
> > SACK option.
> >
> > Since we can't fit any SACK blocks in the final 8 bytes of options space, and
> > the MD5 signature is more important, we disable including SACK, or even
> > advertising it, when MD5 is enabled.
> >
> > Signed-off-by: Adam Langley <agl@imperialviolet.org>
>
> Reviewed-by: James Morris <jmorris@namei.org>
After making some minor coding style fixups, I applied this
fix, thanks everyone.
next prev parent reply other threads:[~2008-06-02 6:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 18:40 [PATCH] Fix corrupt TCP packets when options space overflows with MD5SIG enabled Adam Langley
2008-05-30 19:02 ` Ben Hutchings
2008-05-30 19:11 ` Adam Langley
2008-05-30 19:17 ` Adam Langley
2008-05-30 20:32 ` Stephen Hemminger
2008-05-31 22:01 ` Adam Langley
2008-05-31 21:57 ` Adam Langley
2008-06-01 23:40 ` James Morris
2008-06-02 6:56 ` David Miller [this message]
2008-06-03 16:31 ` Adam Langley
2008-06-03 16:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080601.235649.109450540.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=agl@imperialviolet.org \
--cc=jmorris@namei.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).