From: Arjan van de Ven <arjan@infradead.org>
To: Michael Buesch <mb@bu3sch.de>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: PATCH] net: b44.c fix sleeping-with-spinlock-helt during resume
Date: Sun, 1 Jun 2008 09:01:07 -0700 [thread overview]
Message-ID: <20080601090107.1ed8d5a7@infradead.org> (raw)
In-Reply-To: <200806011203.40437.mb@bu3sch.de>
On Sun, 1 Jun 2008 12:03:40 +0200
Michael Buesch <mb@bu3sch.de> wrote:
> Index: wireless-testing/drivers/ssb/driver_pcicore.c
> ===================================================================
> --- wireless-testing.orig/drivers/ssb/driver_pcicore.c
> 2008-04-23 16:06:56.000000000 +0200 +++
> wireless-testing/drivers/ssb/driver_pcicore.c 2008-06-01
> 12:02:33.000000000 +0200 @@ -537,12 +537,12 @@ int
> ssb_pcicore_dev_irqvecs_enable(struc int err = 0; u32 tmp;
>
> - might_sleep();
> -
> if (!pdev)
> goto out;
> bus = pdev->bus;
>
> + might_sleep_if(pdev->id.coreid != SSB_DEV_PCI);
> +
> /* Enable interrupts for this device. */
> if (bus->host_pci &&
> ((pdev->id.revision >= 6) || (pdev->id.coreid ==
> SSB_DEV_PCIE))) {
>
>
>
fair enough.... can we get something like this into 2.6.26 still? Quite
a few people are hitting this (even though the warning is harmless, it
still is better to silence it)
--
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2008-06-01 16:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-01 3:11 PATCH] net: b44.c fix sleeping-with-spinlock-helt during resume Arjan van de Ven
2008-06-01 10:03 ` Michael Buesch
2008-06-01 16:01 ` Arjan van de Ven [this message]
2008-06-07 6:01 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080601090107.1ed8d5a7@infradead.org \
--to=arjan@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).