netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: Brice Goglin <brice@myri.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org,
	"venkatesh.pallipadi@intel.com" <venkatesh.pallipadi@intel.com>
Subject: Re: howto use ioremap_wc?
Date: Mon, 2 Jun 2008 19:18:32 -0700	[thread overview]
Message-ID: <20080602191832.0858eff9@infradead.org> (raw)
In-Reply-To: <48441F73.5040005@myri.com>

On Mon, 02 Jun 2008 18:27:31 +0200
Brice Goglin <brice@myri.com> wrote:


> 
> Agreed, that would be nice!
> 
> >From what we discussed here after your reply, our plan is now to just
> replace
>     ioremap+mtrr_add

which doesn't work as ioremap() may/will force uncached ;)


> with
>     ioremap_wc+mtrr_add
> 
> If mtrr_add() is moved into ioremap_wc(), we'll remove it from
> myri10ge. For now, when PAT is enabled, we may have PAT + MTRR both
> doing WC, but I don't think it can break anything, right?

Both having WC is nicely consistent and the right thing happens...

-- 
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

  parent reply	other threads:[~2008-06-03  2:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-31  9:02 howto use ioremap_wc? Brice Goglin
2008-06-01  1:54 ` Arjan van de Ven
2008-06-02 16:27   ` Brice Goglin
2008-06-02 18:18     ` Loic Prylli
2008-06-03  2:18     ` Arjan van de Ven [this message]
2008-06-05  4:53   ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080602191832.0858eff9@infradead.org \
    --to=arjan@infradead.org \
    --cc=brice@myri.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).