From: David Miller <davem@davemloft.net>
To: tgraf@suug.ch
Cc: shemminger@vyatta.com, kaber@trash.net,
Stephane_Chazelas@yahoo.fr, netdev@vger.kernel.org
Subject: Re: [PATCH] net: neighbour table ABI problem
Date: Tue, 03 Jun 2008 16:03:27 -0700 (PDT) [thread overview]
Message-ID: <20080603.160327.105786253.davem@davemloft.net> (raw)
In-Reply-To: <20080522002042.GO20815@postel.suug.ch>
From: Thomas Graf <tgraf@suug.ch>
Date: Thu, 22 May 2008 02:20:42 +0200
> * David Miller <davem@davemloft.net> 2008-05-21 13:35
> > From: Stephen Hemminger <shemminger@vyatta.com>
> > Date: Wed, 21 May 2008 10:40:19 -0700
> >
> > > This change is small, but it breaks the ABI for older version of iproute2 utilities.
> > > But these utilities are already broken since they are looking at the psched_hz values
> > > which are completely different. So let's just go ahead and fix both kernel and user
> > > space. Older utilities will just print wrong values.
> > >
> >
> > Can we add a new attribute or something like that?
>
> We could do but I agree with Stephen to just fix it the way he
> proposes. The value we're talking is only useful in a debugging
> or statistical context. We're not changing the format of the
> attribute at all, not even the unit, srictly speaking.
Fair enough, I've applied Stephen's patch.
Thanks.
next prev parent reply other threads:[~2008-06-03 23:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 16:38 [iproute2] get_hz() with CONFIG_HIGH_RES_TIMERS Stephane Chazelas
2008-05-21 16:56 ` Patrick McHardy
2008-05-21 17:40 ` [PATCH] net: neighbour table ABI problem Stephen Hemminger
2008-05-21 20:35 ` David Miller
2008-05-22 0:20 ` Thomas Graf
2008-06-03 23:03 ` David Miller [this message]
2008-05-21 17:10 ` [iproute2] get_hz() with CONFIG_HIGH_RES_TIMERS Stephen Hemminger
2008-05-21 18:43 ` route metrics in jiffies?? Stephen Hemminger
2008-05-21 20:31 ` David Miller
2008-05-22 10:36 ` rtt metric only for incoming connections? Stephane Chazelas
2008-05-27 18:43 ` Stephen Hemminger
2008-05-27 18:53 ` Rick Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080603.160327.105786253.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Stephane_Chazelas@yahoo.fr \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).