netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH 1/2] IPV6: remove addresses and routes when carrier is lost
Date: Tue, 3 Jun 2008 10:21:44 -0700	[thread overview]
Message-ID: <20080603102144.571df55b@extreme> (raw)
In-Reply-To: <20080604.011717.77875207.yoshfuji@linux-ipv6.org>

On Wed, 04 Jun 2008 01:17:17 +0900 (JST)
YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org> wrote:

> In article <20080602165347.5662f602@extreme> (at Mon, 2 Jun 2008 16:53:47 -0700), Stephen Hemminger <shemminger@vyatta.com> says:
> 
> > Similar to previous change for IPV4. Allow configuration option to remove
> > addresses from FIB when carrier is lost.
> > 
> > This patch also makes IPV6 ignore changes to carrier state when device
> > is admin down state. This prevents address configuration from starting
> > up on a buggy device driver that signals carrier changes when offline.
> > 
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> 
> Well, we need to be careful here.
> IMHO we should not remove addresses (especially link-local address
> based on MAC, or manually assigned addresses, maybe).
> We might want to do Optimistic DAD here.
> 
> --yoshfuji

The patch just makes carrier_off respond the same as doing 'ip link set dev eth0 down'
(or ifconfig eth0 down). A router needs to be able to re-route when link fails.

  reply	other threads:[~2008-06-03 17:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-02 23:52 [PATCH 1/2] IPV4: remove addresses and routes when carrier is lost Stephen Hemminger
2008-06-02 23:53 ` [PATCH 1/2] IPV6: " Stephen Hemminger
2008-06-03 16:17   ` YOSHIFUJI Hideaki / 吉藤英明
2008-06-03 17:21     ` Stephen Hemminger [this message]
2008-06-03 17:25       ` David Miller
2008-06-03 17:28         ` Patrick McHardy
2008-06-03 17:31           ` David Miller
2008-06-03 17:28         ` YOSHIFUJI Hideaki / 吉藤英明
2008-06-03 17:30           ` David Miller
2008-06-03 17:46             ` Stephen Hemminger
2008-06-03 17:53               ` David Miller
2008-06-03 18:34                 ` Stephen Hemminger
2008-06-03 19:06                   ` David Miller
2008-06-03 21:40                     ` Stephen Hemminger
2008-06-03 15:05 ` [PATCH 1/2] IPV4: " Lennart Sorensen
2008-06-03 15:57   ` Stephen Hemminger
2008-06-03 16:03     ` Patrick McHardy
2008-06-03 16:31       ` Stephen Hemminger
2008-06-03 16:44         ` Patrick McHardy
2008-06-03 21:45       ` Lennart Sorensen
2008-06-03 22:32         ` Patrick McHardy
2008-06-04 13:53           ` Lennart Sorensen
2008-06-03 21:44     ` Lennart Sorensen
2008-06-06 14:56 ` Lennart Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080603102144.571df55b@extreme \
    --to=shemminger@vyatta.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).