From: David Miller <davem@davemloft.net>
To: jchapman@katalix.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2][L2TP]: Fix possible WARN_ON from socket code when UDP socket is closed
Date: Wed, 04 Jun 2008 15:08:35 -0700 (PDT) [thread overview]
Message-ID: <20080604.150835.73786340.davem@davemloft.net> (raw)
In-Reply-To: <200806042056.m54KuiI7003060@quickie.katalix.com>
From: James Chapman <jchapman@katalix.com>
Date: Wed, 4 Jun 2008 21:56:44 +0100
> If an L2TP daemon closes a tunnel socket while packets are queued in
> the tunnel's reorder queue, a kernel warning is logged because the
> socket is closed while skbs are still referencing it. The fix is to
> purge the queue in the socket's release handler.
>
> WARNING: at include/net/sock.h:351 udp_lib_unhash+0x41/0x68()
> Pid: 12998, comm: openl2tpd Not tainted 2.6.25 #8
> [<c0423c58>] warn_on_slowpath+0x41/0x51
> [<c05d33a7>] udp_lib_unhash+0x41/0x68
> [<c059424d>] sk_common_release+0x23/0x90
> [<c05d16be>] udp_lib_close+0x8/0xa
> [<c05d8684>] inet_release+0x42/0x48
> [<c0592599>] sock_release+0x14/0x60
> [<c059299f>] sock_close+0x29/0x30
> [<c046ef52>] __fput+0xad/0x15b
> [<c046f1d9>] fput+0x17/0x19
> [<c046c8c4>] filp_close+0x50/0x5a
> [<c046da06>] sys_close+0x69/0x9f
> [<c04048ce>] syscall_call+0x7/0xb
>
> Signed-off-by: James Chapman <jchapman@katalix.com>
Applied, thanks.
next prev parent reply other threads:[~2008-06-04 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 20:56 [PATCH 1/2][L2TP]: Fix possible WARN_ON from socket code when UDP socket is closed James Chapman
2008-06-04 22:08 ` David Miller [this message]
2008-06-04 22:11 ` David Miller
2008-06-04 22:33 ` James Chapman
2008-06-04 22:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080604.150835.73786340.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).