From: David Miller <davem@davemloft.net>
To: opurdila@ixiacom.com
Cc: netdev@vger.kernel.org
Subject: Re: TCP_SKB_CB(skb)->flags = iph->tos ?
Date: Wed, 04 Jun 2008 15:26:07 -0700 (PDT) [thread overview]
Message-ID: <20080604.152607.170576716.davem@davemloft.net> (raw)
In-Reply-To: <200805302353.56440.opurdila@ixiacom.com>
From: Octavian Purdila <opurdila@ixiacom.com>
Date: Fri, 30 May 2008 23:53:56 +0300
>
> tcp_v4_rcv says: TCP_SKB_CB(skb)->flags = iph->tos;
>
> I am probably missing something obvious, but shouldn't flags be initialized
> with the TCP headers instead of the IP TOS value?
On packet output ->flags holds the TCP header flags, on packet input
it holds the TOS field for testing ECN flags.
You could have had a look at how the ->flags field is used on TCP
output vs. TCP input processing to get a better idea of what might be
going on here.
That's exactly how I figured it out, I didn't know the answer either,
but constantly I'm doing simple searches for people and learning the
code for other people it seems even when I really don't even have
the time to do so :-/
next prev parent reply other threads:[~2008-06-04 22:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 20:53 TCP_SKB_CB(skb)->flags = iph->tos ? Octavian Purdila
2008-06-04 22:26 ` David Miller [this message]
2008-06-05 11:55 ` Octavian Purdila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080604.152607.170576716.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=opurdila@ixiacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).