netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: "Subbu Seetharaman" <subbus@serverengines.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/12] BE NIC driver - Header files and initialization functions
Date: Wed, 4 Jun 2008 10:11:33 -0700	[thread overview]
Message-ID: <20080604101133.2188c8f6@extreme> (raw)
In-Reply-To: <20080604082514.241e7aad@mailhost.serverengines.com>

On Wed, 04 Jun 2008 01:25:14 -0700
"Subbu Seetharaman" <subbus@serverengines.com> wrote:

> Thanks for you comments Stephen.  
> 
> We did not make MSIx the default since most testing
> was done with INTx.  Since this version of the driver does not use multiple
> interrupt vectors, there is no performance advantage in using MSIx.
> If MSIx is still the preferred default, we can change it.

MSIx isn't shared but INTx is so there is at least some gain on big systems.

> 
> NAPI makes tasklet redundant in the RX completion processing; but
> we felt deffering TX completion processing to a tasklet is a better
> idea for 10Gb data rates than doing it in hard interrupt.

Okay, other drivers do TX completion processing  in NAPI handler.
It has the advantage of rate limiting the the TX completion in case
of really high transmit load.

> I will get back soon with other comments taken care of.
> 
> Subbu
>

  reply	other threads:[~2008-06-04 17:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-04  8:25 [PATCH 1/12] BE NIC driver - Header files and initialization functions Subbu Seetharaman
2008-06-04 17:11 ` Stephen Hemminger [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-06-03  9:37 Subbu Seetharaman
2008-06-03 17:16 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080604101133.2188c8f6@extreme \
    --to=shemminger@vyatta.com \
    --cc=netdev@vger.kernel.org \
    --cc=subbus@serverengines.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).