netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [RFC] Running single tests via ethtool
Date: Wed, 4 Jun 2008 15:13:50 +0100	[thread overview]
Message-ID: <20080604141349.GA11300@solarflare.com> (raw)
In-Reply-To: <48443207.5090009@garzik.org>

Jeff Garzik wrote:
[...]
> Well it really becomes of question of whether or not you want to be 
> importing a huge test suite into a kernel driver.  The ethtool stuff was 
> not meant to cover exhaustive tests, just a way to run "it works" 
> self-checks and diagnostics.

We're not intending to expand the tests massively, though there are a few
that should be added.  We just want to pick which to run.  I'm not entirely
clear why the customer wants this, but I can imagine wanting to run a single
test repeatedly if some aspect of a board is suspected to be intermittently
faulty.  Since there is no firmware in our current controller, the
initialisation is fairly complex and we wouldn't want to duplicate it outside
the driver in a standalone diagnostic program.  Besides which, unloading a
driver and keeping it unloaded seems to be increasingly tricky.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.

      reply	other threads:[~2008-06-04 14:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-30 22:08 [RFC] Running single tests via ethtool Ben Hutchings
2008-06-02 17:00 ` Ingo Oeser
2008-06-02 17:46 ` Jeff Garzik
2008-06-04 14:13   ` Ben Hutchings [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080604141349.GA11300@solarflare.com \
    --to=bhutchings@solarflare.com \
    --cc=jeff@garzik.org \
    --cc=linux-net-drivers@solarflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).