TCP_SKB_CB(skb)->flags = iph->tos ?

TCP_SKB_CB(skb)->flags = iph->tos ?

[Octavian Purdila]

tcp_v4_rcv says: TCP_SKB_CB(skb)->flags = iph->tos;

I am probably missing something obvious, but shouldn't flags be initialized 
with the TCP headers instead of the IP TOS value?

Thanks,
tavi

Re: TCP_SKB_CB(skb)->flags = iph->tos ?

[David Miller]

From: Octavian Purdila <opurdila@ixiacom.com>
Date: Fri, 30 May 2008 23:53:56 +0300

> 
> tcp_v4_rcv says: TCP_SKB_CB(skb)->flags = iph->tos;
> 
> I am probably missing something obvious, but shouldn't flags be initialized 
> with the TCP headers instead of the IP TOS value?

On packet output ->flags holds the TCP header flags, on packet input
it holds the TOS field for testing ECN flags.

You could have had a look at how the ->flags field is used on TCP
output vs. TCP input processing to get a better idea of what might be
going on here.

That's exactly how I figured it out, I didn't know the answer either,
but constantly I'm doing simple searches for people and learning the
code for other people it seems even when I really don't even have
the time to do so :-/

Re: TCP_SKB_CB(skb)->flags = iph->tos ?

[Octavian Purdila]

>
> That's exactly how I figured it out, I didn't know the answer either,
> but constantly I'm doing simple searches for people and learning the
> code for other people it seems even when I really don't even have
> the time to do so :-/


Apologies, I did not pay attention to my grep output and was under the 
impression that ->flags is only used together with the TCP headers and that 
the ip->tos assignment was never used.

Thanks,
tavi