* [2.6 patch] include/linux/ssb/ssb_driver_gige.h typo fix
@ 2008-06-05 18:29 Adrian Bunk
2008-06-05 18:34 ` Robert P. J. Day
2008-06-05 18:42 ` Michael Buesch
0 siblings, 2 replies; 3+ messages in thread
From: Adrian Bunk @ 2008-06-05 18:29 UTC (permalink / raw)
To: Michael Buesch, John W. Linville; +Cc: netdev, linux-kernel, Robert P. J. Day
This patch fixes a typo in the name of a config variable.
Reported-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
2aab8eeb46b30baf987c344e1b144caec365373a diff --git a/include/linux/ssb/ssb_driver_gige.h b/include/linux/ssb/ssb_driver_gige.h
index 01fbdf5..942e387 100644
--- a/include/linux/ssb/ssb_driver_gige.h
+++ b/include/linux/ssb/ssb_driver_gige.h
@@ -100,7 +100,7 @@ extern char * nvram_get(const char *name);
/* Get the device MAC address */
static inline void ssb_gige_get_macaddr(struct pci_dev *pdev, u8 *macaddr)
{
-#ifdef CONFIG_BCM947XX
+#ifdef CONFIG_BCM47XX
char *res = nvram_get("et0macaddr");
if (res)
memcpy(macaddr, res, 6);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [2.6 patch] include/linux/ssb/ssb_driver_gige.h typo fix
2008-06-05 18:29 [2.6 patch] include/linux/ssb/ssb_driver_gige.h typo fix Adrian Bunk
@ 2008-06-05 18:34 ` Robert P. J. Day
2008-06-05 18:42 ` Michael Buesch
1 sibling, 0 replies; 3+ messages in thread
From: Robert P. J. Day @ 2008-06-05 18:34 UTC (permalink / raw)
To: Adrian Bunk
Cc: Michael Buesch, John W. Linville, netdev,
Linux Kernel Mailing List, Ralf Baechle
On Thu, 5 Jun 2008, Adrian Bunk wrote:
> This patch fixes a typo in the name of a config variable.
>
> Reported-by: Robert P. J. Day <rpjday@crashcourse.ca>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
> 2aab8eeb46b30baf987c344e1b144caec365373a diff --git a/include/linux/ssb/ssb_driver_gige.h b/include/linux/ssb/ssb_driver_gige.h
> index 01fbdf5..942e387 100644
> --- a/include/linux/ssb/ssb_driver_gige.h
> +++ b/include/linux/ssb/ssb_driver_gige.h
> @@ -100,7 +100,7 @@ extern char * nvram_get(const char *name);
> /* Get the device MAC address */
> static inline void ssb_gige_get_macaddr(struct pci_dev *pdev, u8 *macaddr)
> {
> -#ifdef CONFIG_BCM947XX
> +#ifdef CONFIG_BCM47XX
> char *res = nvram_get("et0macaddr");
> if (res)
> memcpy(macaddr, res, 6);
>
just FYI, there are more (admittedly aesthetic) references to
BCM947XX in the MIPS directory:
$ grep -r "BCM947XX" *
include/linux/ssb/ssb_driver_gige.h:#ifdef CONFIG_BCM947XX
include/asm-mips/mach-bcm47xx/war.h:#ifndef __ASM_MIPS_MACH_BCM947XX_WAR_H
include/asm-mips/mach-bcm47xx/war.h:#define __ASM_MIPS_MACH_BCM947XX_WAR_H
include/asm-mips/mach-bcm47xx/war.h:#endif /* __ASM_MIPS_MACH_BCM947XX_WAR_H */
$
whether you want to do anything about those is up to you.
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.
http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [2.6 patch] include/linux/ssb/ssb_driver_gige.h typo fix
2008-06-05 18:29 [2.6 patch] include/linux/ssb/ssb_driver_gige.h typo fix Adrian Bunk
2008-06-05 18:34 ` Robert P. J. Day
@ 2008-06-05 18:42 ` Michael Buesch
1 sibling, 0 replies; 3+ messages in thread
From: Michael Buesch @ 2008-06-05 18:42 UTC (permalink / raw)
To: Adrian Bunk; +Cc: John W. Linville, netdev, linux-kernel, Robert P. J. Day
On Thursday 05 June 2008 20:29:49 Adrian Bunk wrote:
> This patch fixes a typo in the name of a config variable.
Well, it's not a typo. It was renamed. Good catch anyway. :)
> Reported-by: Robert P. J. Day <rpjday@crashcourse.ca>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Reviewed-by: Michael Buesch <mb@bu3sch.de>
> ---
> 2aab8eeb46b30baf987c344e1b144caec365373a diff --git a/include/linux/ssb/ssb_driver_gige.h b/include/linux/ssb/ssb_driver_gige.h
> index 01fbdf5..942e387 100644
> --- a/include/linux/ssb/ssb_driver_gige.h
> +++ b/include/linux/ssb/ssb_driver_gige.h
> @@ -100,7 +100,7 @@ extern char * nvram_get(const char *name);
> /* Get the device MAC address */
> static inline void ssb_gige_get_macaddr(struct pci_dev *pdev, u8 *macaddr)
> {
> -#ifdef CONFIG_BCM947XX
> +#ifdef CONFIG_BCM47XX
> char *res = nvram_get("et0macaddr");
> if (res)
> memcpy(macaddr, res, 6);
>
>
>
--
Greetings Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-06-05 18:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-05 18:29 [2.6 patch] include/linux/ssb/ssb_driver_gige.h typo fix Adrian Bunk
2008-06-05 18:34 ` Robert P. J. Day
2008-06-05 18:42 ` Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).