From: frank.blaschka@de.ibm.com
To: jgarzik@pobox.com
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [patch 1/5] qeth: layer 3 Oops in ip event handler
Date: Fri, 06 Jun 2008 12:37:44 +0200 [thread overview]
Message-ID: <20080606103827.637655000@de.ibm.com> (raw)
In-Reply-To: 20080606103743.638691000@de.ibm.com
[-- Attachment #1: 600-qeth-l3-oops.diff --]
[-- Type: text/plain, Size: 890 bytes --]
From: Frank Blaschka <frank.blaschka@de.ibm.com>
The ip event handler may present us non qeth network interfaces.
Add qeth card pointer check.
Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
---
drivers/s390/net/qeth_l3_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -urpN linux-2.6/drivers/s390/net/qeth_l3_main.c linux-2.6-patched/drivers/s390/net/qeth_l3_main.c
--- linux-2.6/drivers/s390/net/qeth_l3_main.c 2008-06-06 10:52:45.000000000 +0200
+++ linux-2.6-patched/drivers/s390/net/qeth_l3_main.c 2008-06-06 10:53:11.000000000 +0200
@@ -2070,7 +2070,7 @@ static struct qeth_card *qeth_l3_get_car
card = netdev_priv(dev);
else if (rc == QETH_VLAN_CARD)
card = netdev_priv(vlan_dev_info(dev)->real_dev);
- if (card->options.layer2)
+ if (card && card->options.layer2)
card = NULL;
QETH_DBF_TEXT_(TRACE, 4, "%d", rc);
return card ;
--
next prev parent reply other threads:[~2008-06-06 10:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-06 10:37 [patch 0/5] s390: qeth fixes for 2.6.26 frank.blaschka
2008-06-06 10:37 ` frank.blaschka [this message]
2008-06-06 10:37 ` [patch 2/5] qeth: Use ccw_device_get_id() frank.blaschka
2008-06-06 10:37 ` [patch 3/5] qeth: reduce number of kernel messages frank.blaschka
2008-06-06 10:37 ` [patch 4/5] qeth: Prepare-function to call s390dbf was wrong frank.blaschka
2008-06-06 10:37 ` [patch 5/5] qeth: start dev queue after tx drop error frank.blaschka
2008-06-10 22:21 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080606103827.637655000@de.ibm.com \
--to=frank.blaschka@de.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).