From: Ben Hutchings <bhutchings@solarflare.com>
To: Malli <mchilakala@gmail.com>
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
jeff@garzik.org
Subject: Re: [PATCH 2/2] ixgbe: add LRO support
Date: Wed, 11 Jun 2008 11:16:29 +0100 [thread overview]
Message-ID: <20080611101628.GQ11300@solarflare.com> (raw)
In-Reply-To: <7991c5480806101247h586993a1o31e136484e30bc8f@mail.gmail.com>
Malli wrote:
> Forwarding my reply. It got rejected from netdev list, as it was sent in HTML
>
> Thanks for your feedback Ben. I'll update the patch with ethtool get
> and set flags. But in packet split mode we still wouldn't want to
> limit this with MAX_SKB_FRAGS because we don't actually add the frags
> to the previous packet. They just chain them together using the
> frag_list and next pointers in the skb. Let me know if it still
> doesn't address your concern in max aggregation.
Yes, I understood that. I wasn't sure whether MAX_SKB_FRAGS was also meant
to be a limit on the frag_list. The comment above its definition implies
quite strongly that it isn't, so there's no problem.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
next prev parent reply other threads:[~2008-06-11 10:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 22:57 [PATCH 1/2] ixgbe: fix typo Jeff Kirsher
2008-06-09 22:57 ` [PATCH 2/2] ixgbe: add LRO support Jeff Kirsher
2008-06-09 23:26 ` Ben Hutchings
2008-06-10 19:33 ` Malli
2008-06-10 19:47 ` Malli
2008-06-11 10:16 ` Ben Hutchings [this message]
2008-06-10 22:22 ` [PATCH 1/2] ixgbe: fix typo Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080611101628.GQ11300@solarflare.com \
--to=bhutchings@solarflare.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=mchilakala@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).