From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Rafael Almeida" <almeidaraf@gmail.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Fixed NetEm's reorder option
Date: Wed, 11 Jun 2008 14:49:18 -0700 [thread overview]
Message-ID: <20080611144918.1668e3d8@extreme> (raw)
In-Reply-To: <6de6b1650806111305m51bf2eccocbe0d0c7afee266d@mail.gmail.com>
On Wed, 11 Jun 2008 17:05:10 -0300
"Rafael Almeida" <almeidaraf@gmail.com> wrote:
> I noticed no one said anything about my patch below, did I do
> something terrible wrong? Should I just be more patient?
>
> On Thu, Jun 5, 2008 at 1:34 AM, Rafael C. de Almeida
> <almeidaraf@gmail.com> wrote:
> > The reorder option wasn't working correctly. It would only kick in if
> > the gap option was set. In that case it would only lower the
> > probability of reordering packets because of how the if conditional
> > was stated.
> >
> > This patch separetes the algorithm for reordering with gap from the
> > rest, rendering the code more readable and correct.
> >
> > Signed-off-by: Rafael C. de Almeida <rafaelc@dcc.ufmg.br>
Haven't had time to look at this in detail, and I worry about the impact
of changing assumptions people already have in their scripts.
prev parent reply other threads:[~2008-06-11 21:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <48479f6a.e203be0a.73e1.fffff59b@mx.google.com>
2008-06-11 20:05 ` [PATCH] Fixed NetEm's reorder option Rafael Almeida
2008-06-11 21:49 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080611144918.1668e3d8@extreme \
--to=shemminger@linux-foundation.org \
--cc=almeidaraf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox