netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: jeff@garzik.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, davem@daveloft.org
Subject: Re: [PATCH] [UPDATED] ixgbe: add LRO support
Date: Fri, 13 Jun 2008 09:38:35 -0700	[thread overview]
Message-ID: <20080613093835.4b092360.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20080613162643.27996.32104.stgit@localhost.localdomain>

On Fri, 13 Jun 2008 09:30:29 -0700 Jeff Kirsher wrote:

> From: Mallikarjuna R Chilakala <mallikarjuna.chilakala@intel.com>
> 
> Support for in-kernel LRO with the ability to enable/disable via ethtool
> based on comments from Ben Hutchings and Randy Dunlap.
> 
> 
> Signed-off-by: Mallikarjuna R Chilakala <mallikarjuna.chilakala@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Signed-off-by: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>
> ---
> 
>  drivers/net/Kconfig               |    1 
>  drivers/net/ixgbe/ixgbe.h         |    9 +++
>  drivers/net/ixgbe/ixgbe_ethtool.c |   11 ++++
>  drivers/net/ixgbe/ixgbe_main.c    |  111 ++++++++++++++++++++++++++++++-------
>  4 files changed, 111 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index af46341..f6a15ed 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2451,6 +2451,7 @@ config EHEA
>  config IXGBE
>  	tristate "Intel(R) 10GbE PCI Express adapters support"
>  	depends on PCI

+	depends on PCI && INET

> +	select INET_LRO

If INET is not enabled, selecting INET_LRO still won't enable INET and
build errors will result.  See the other drivers that select INET_LRO...


>  	---help---
>  	  This driver supports Intel(R) 10GbE PCI Express family of
>  	  adapters.  For more information on how to identify your adapter, go


---
~Randy
'"Daemon' is an old piece of jargon from the UNIX operating system,
where it referred to a piece of low-level utility software, a
fundamental part of the operating system."

  reply	other threads:[~2008-06-13 16:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-13 16:30 [PATCH] [UPDATED] ixgbe: add LRO support Jeff Kirsher
2008-06-13 16:38 ` Randy Dunlap [this message]
2008-06-13 17:29   ` Jeff Kirsher
  -- strict thread matches above, loose matches on Subject: below --
2008-06-13 18:40 Jeff Kirsher
2008-06-13 18:45 ` Randy Dunlap
2008-06-18  4:04 ` Jeff Garzik
2008-06-18 22:32   ` Jeff Kirsher
2008-06-18 22:32 Jeff Kirsher
2008-06-25  3:09 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080613093835.4b092360.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=davem@daveloft.org \
    --cc=jeff@garzik.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).