netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Dooks <ben-linux@fluff.org>
To: Bryan Wu <cooloney@kernel.org>
Cc: Laurent Pinchart <laurentp@cse-semaphore.com>,
	netdev@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>
Subject: Re: dm9000: Remove the 2 resources probe scheme.
Date: Sun, 15 Jun 2008 22:49:04 +0100	[thread overview]
Message-ID: <20080615214904.GR31817@trinity.fluff.org> (raw)
In-Reply-To: <386072610806130729k77d1801lb615ffafb3d0117f@mail.gmail.com>

On Fri, Jun 13, 2008 at 10:29:45PM +0800, Bryan Wu wrote:
> On Fri, Jun 13, 2008 at 8:58 PM, Laurent Pinchart
> <laurentp@cse-semaphore.com> wrote:
> > The dm9000 driver accepts either 2 or 3 resources to describe the platform
> > devices. The 2 resources case abuses the ioresource mechanism by passing
> > ioremap()ed memory through the platform device resources. This patch removes
> > that case and converts boards that were using it to the 3 resources scheme.
> >
> > Signed-off-by: Laurent Pinchart <laurentp@cse-semaphore.com>
> > ---
> >  arch/blackfin/mach-bf527/boards/ezkit.c         |    7 ++-
> >  arch/blackfin/mach-bf533/boards/H8606.c         |    7 ++-
> >  arch/blackfin/mach-bf537/boards/generic_board.c |    7 ++-
> >  arch/blackfin/mach-bf537/boards/stamp.c         |    7 ++-
> 
> IMO, this patch can be split into two parts, one for Blackfin and the
> other for dm9000 driver.

I think I agree with that, although I would also like to make sure the
blackfin part of this is tested. I am also trying to get rid of the
defines for blackfin specific compile, as they shouldn't be in the
driver!

I've queued the dm9000 specific bits into my own little dm9000 tree
for the next kernel release.

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.


  reply	other threads:[~2008-06-15 21:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-13 12:58 dm9000: Remove the 2 resources probe scheme Laurent Pinchart
2008-06-13 14:29 ` Bryan Wu
2008-06-15 21:49   ` Ben Dooks [this message]
2008-06-16  8:46     ` Laurent Pinchart
2008-06-16 13:09       ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080615214904.GR31817@trinity.fluff.org \
    --to=ben-linux@fluff.org \
    --cc=cooloney@kernel.org \
    --cc=laurentp@cse-semaphore.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).