From: David Miller <davem@davemloft.net>
To: xemul@openvz.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/8] netns: optimize tcp and udp hashtables wrt net namespaces
Date: Mon, 16 Jun 2008 17:14:59 -0700 (PDT) [thread overview]
Message-ID: <20080616.171459.40244811.davem@davemloft.net> (raw)
In-Reply-To: <485633E4.10900@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Mon, 16 Jun 2008 13:35:32 +0400
> Currently hash functions to store udp sockets, bind buckets,
> listening and established tcp sockets take only ports and/or
> addresses into account.
>
> The result is nasty. Consider processes in different namespaces
> communicate to each other or the outer world with same ports
> or addresses (e.g. dns server run in each namespace, apache server
> listening a 80 port in each ns or communications via lo). All
> these sockets will all be linked in a single hash chain, thus
> producing too long chains.
>
> To avoid this situation the proposal is to add some "salt" to
> hash functions taking the namespace into account.
>
> I made this "salt" disappear for CONFIG_NET_NS=n case.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Looks great. I've applied this to net-next-2.6 and will push
back out to kernel.org after some build testing.
Thanks!
prev parent reply other threads:[~2008-06-17 0:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 9:35 [PATCH net-next 0/8] netns: optimize tcp and udp hashtables wrt net namespaces Pavel Emelyanov
2008-06-16 9:38 ` [PATCH net-next 1/8] UDP: introduce a udp_hashfn function Pavel Emelyanov
2008-06-16 9:40 ` [PATCH net-next 2/8] UDP: provide a struct net pointer for __udp[46]_lib_mcast_deliver Pavel Emelyanov
2008-06-16 9:41 ` [PATCH net-next 3/8] UDP: add struct net argument to udp_hashfn Pavel Emelyanov
2008-06-16 9:43 ` [PATCH net-next 4/8] Inet: add struct net argument to inet_bhashfn Pavel Emelyanov
2008-06-16 9:44 ` [PATCH net-next 5/8] Inet: add struct net argument to inet_lhashfn Pavel Emelyanov
2008-06-16 9:47 ` [PATCH net-next 6/8] Inet: add struct net argument to inet_ehashfn Pavel Emelyanov
2008-06-16 9:48 ` [PATCH net-next 7/8] Inet6: add struct net argument to inet6_ehashfn Pavel Emelyanov
2008-06-16 9:51 ` [PATCH net-next 8/8] Netns: introduce the net_hash_mix "salt" for hashes Pavel Emelyanov
2008-06-17 0:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080616.171459.40244811.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).