From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: eilong@broadcom.com, netdev@vger.kernel.org, mchan@broadcom.com,
vladz@broadcom.com
Subject: Re: [PATCH net-next 11/15]bnx2x: Add TPA, Broadcoms HW LRO
Date: Tue, 17 Jun 2008 16:16:40 -0700 (PDT) [thread overview]
Message-ID: <20080617.161640.256235010.davem@davemloft.net> (raw)
In-Reply-To: <20080617151704.GK5350@solarflare.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Tue, 17 Jun 2008 16:17:06 +0100
> Ben Hutchings wrote:
> > Eilon Greenstein wrote:
> > > The TPA stands for Transparent Packet Aggregation. When enabled, the FW
> > > aggregate in-order TCP packets according to the 4-tuple match and sends
> > > 1 big packet to the driver. This packet is stored on an SGL in which
> > > each SGE is 1 page. The FW also implements a timeout algorithm and it
> > > honors all TCP flag, including the push flag as a trigger to halt
> > > aggregation.
> > [...]
> >
> > LRO is not compatible with forwarding and will currently trigger a BUG() or
> > WARN() if used on packets that are then forwarded.
>
> Actually, since this implementation doesn't set gso_size in LRO'd skbs, it
> will confuse TCP in interesting ways instead. You need to set gso_size to
> the largest segment size seen in the packets that were aggregated.
Eilon, please sort this out, thanks.
next prev parent reply other threads:[~2008-06-17 23:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 14:49 [PATCH net-next 11/15]bnx2x: Add TPA, Broadcoms HW LRO Eilon Greenstein
2008-06-17 15:05 ` Ben Hutchings
2008-06-17 15:17 ` Ben Hutchings
2008-06-17 23:16 ` David Miller [this message]
2008-06-19 17:42 ` Eilon Greenstein
2008-06-19 18:20 ` Ben Hutchings
2008-06-19 21:50 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2008-06-23 16:02 Eilon Greenstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080617.161640.256235010.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=eilong@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vladz@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).