From: "Denys Fedoryshchenko" <denys@visp.net.lb>
To: David Miller <davem@davemloft.net>, devik@cdi.cz
Cc: jdb@comx.dk, netdev@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH 0/2] HTB scheduler HTB_HYSTERESIS modifications
Date: Tue, 17 Jun 2008 04:00:19 +0300 [thread overview]
Message-ID: <20080617005938.M55099@visp.net.lb> (raw)
In-Reply-To: <20080616.164032.197767785.davem@davemloft.net>
On Mon, 16 Jun 2008 16:40:32 -0700 (PDT), David Miller wrote
> From: Martin Devera <devik@cdi.cz>
> Date: Sat, 14 Jun 2008 11:18:00 +0200
>
> > > I have now tested/deployed the patches on two production servers.
> > >
> > > Conclusion is: It should be safe to apply these patches.
> > >
> > > See full report here:
> > >
http://people.netfilter.org/hawk/patches/htb_nohyst/production_test_results.html
> > >
> > > We saw an increased number of interrupts on the test system, when
> > > enabling/disabling htb_hysteresis.
> > >
> > > This didn't show up on the production system.
> > >
> > > I believe that the increased intr (on test system) is an artifact of the
> > > TCP download got less bursty and more smooth.
> >
> > Which reminds me again, maybe after some time with hysteresis=off we
> > could remove it altogether...
> >
> > Sorry for the delay, I got some flu or what. On my smaller dualcore
> > system there is also no noticeable (performance) impact.
> >
> > I ACK Jesper's patches, thanks for the work and real-world testing!
>
> I've applied Jesper's work to net-2.6, as it is primarily a bug
> fix of sorts and safe because a backwards compatible knob is
> provided just in case it does cause problems for people.
>
> Thanks everyone!
I test this patch too, works fine on loaded system. No significant load
increase, works perfect.
--
Denys Fedoryshchenko
Technical Manager
Virtual ISP S.A.L.
prev parent reply other threads:[~2008-06-17 1:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-03 14:03 [PATCH 0/2] HTB scheduler HTB_HYSTERESIS modifications Jesper Dangaard Brouer
2008-06-03 14:05 ` [PATCH 1/2] HTB scheduler, change default hysteresis mode to off Jesper Dangaard Brouer
2008-06-03 14:06 ` [PATCH 2/2] Change HTB_HYSTERESIS to a runtime parameter htb_hysteresis Jesper Dangaard Brouer
2008-06-04 13:05 ` [PATCH 0/2] HTB scheduler HTB_HYSTERESIS modifications Martin Devera
2008-06-04 14:28 ` Jesper Dangaard Brouer
2008-06-04 15:31 ` Martin Devera
2008-06-12 10:01 ` Jesper Dangaard Brouer
2008-06-14 9:18 ` Martin Devera
2008-06-16 23:40 ` David Miller
2008-06-17 1:00 ` Denys Fedoryshchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080617005938.M55099@visp.net.lb \
--to=denys@visp.net.lb \
--cc=davem@davemloft.net \
--cc=devik@cdi.cz \
--cc=jdb@comx.dk \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).