From: Stephen Hemminger <shemminger@vyatta.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org
Subject: [PATCH 1/5] sky2: phy setup changes
Date: Tue, 17 Jun 2008 09:04:24 -0700 [thread overview]
Message-ID: <20080617160503.360344972@vyatta.com> (raw)
In-Reply-To: 20080617160423.205070938@vyatta.com
[-- Attachment #1: sky2-phy2.patch --]
[-- Type: text/plain, Size: 1093 bytes --]
Change the setup of the PHY registers on some chip ids. These changes
make the latest sky2 driver follow the vendor driver.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/sky2.c 2008-06-16 09:38:33.000000000 -0700
+++ b/drivers/net/sky2.c 2008-06-16 09:38:34.000000000 -0700
@@ -659,8 +659,7 @@ static void sky2_phy_init(struct sky2_hw
ledover |= PHY_M_LED_MO_RX(MO_LED_OFF);
}
- if (hw->chip_id == CHIP_ID_YUKON_EC_U &&
- hw->chip_rev == CHIP_REV_YU_EC_U_A1) {
+ if (hw->chip_id == CHIP_ID_YUKON_EC_U) {
/* apply fixes in PHY AFE */
gm_phy_write(hw, port, PHY_MARV_EXT_ADR, 255);
@@ -679,7 +678,8 @@ static void sky2_phy_init(struct sky2_hw
/* apply workaround for integrated resistors calibration */
gm_phy_write(hw, port, PHY_MARV_PAGE_ADDR, 17);
gm_phy_write(hw, port, PHY_MARV_PAGE_DATA, 0x3f60);
- } else if (hw->chip_id != CHIP_ID_YUKON_EX) {
+ } else if (hw->chip_id != CHIP_ID_YUKON_EX &&
+ hw->chip_id < CHIP_ID_YUKON_SUPR) {
/* no effect on Yukon-XL */
gm_phy_write(hw, port, PHY_MARV_LED_CTRL, ledctrl);
--
next prev parent reply other threads:[~2008-06-17 16:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 16:04 [PATCH 0/5] sky2: driver update for 2.6.27 Stephen Hemminger
2008-06-17 16:04 ` Stephen Hemminger [this message]
2008-06-18 3:31 ` [PATCH 1/5] sky2: phy setup changes Jeff Garzik
2008-06-17 16:04 ` [PATCH 2/5] sky2: chip version printout Stephen Hemminger
2008-06-17 16:04 ` [PATCH 3/5] sky2: use DEFINE_PCI_DEVICE_TABLE Stephen Hemminger
2008-06-17 16:04 ` [PATCH 4/5] sky2: 88E8057 chip support Stephen Hemminger
2008-06-17 16:04 ` [PATCH 5/5] sky2: version 1.22 Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080617160503.360344972@vyatta.com \
--to=shemminger@vyatta.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).