netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: billfink@mindspring.com
Cc: agl@imperialviolet.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Fix corrupt TCP packets when options space overflows with MD5SIG enabled (v2)
Date: Wed, 18 Jun 2008 01:52:06 -0700 (PDT)	[thread overview]
Message-ID: <20080618.015206.22767411.davem@davemloft.net> (raw)
In-Reply-To: <20080618023446.aba6516c.billfink@mindspring.com>

From: Bill Fink <billfink@mindspring.com>
Date: Wed, 18 Jun 2008 02:34:46 -0400

> I am not particularly familiar with the TCP MD5 option, but in googling
> around I found the following at the end of Section 2.2 Transmission,
> of RFC 4808, "TCP-MD5 Key Change", dated March 2007:
> 
>     "Note that there is an ambiguity when an acknowledgment is received
>     for a segment transmitted with two different keys.  The TCP Timestamp
>     option [RFC1323] can be used for disambiguation."
> 
> This would seem to imply, that at least in some scenarios, it would be
> advisable to have TS enabled in conjunction with MD5.

That does change the situation a bit, yes.

It's pretty easy, depending upon the timestamp resolution, to
end up with the original transmit and the retransmit having
the same timetsamp value.  So this suggestion in the RFC is
I think not a complete solution.

  reply	other threads:[~2008-06-18  8:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-03 21:52 [PATCH] Fix corrupt TCP packets when options space overflows with MD5SIG enabled (v2) Adam Langley
2008-06-18  0:07 ` David Miller
2008-06-18  0:45   ` Adam Langley
2008-06-18  4:03     ` David Miller
2008-06-18  6:34     ` Bill Fink
2008-06-18  8:52       ` David Miller [this message]
2008-06-18 19:39         ` Adam Langley
2008-06-18 22:01           ` David Miller
2008-06-18 23:24             ` Comments requested: Long options and MD5 options Adam Langley
2008-06-18 23:36               ` David Miller
2008-06-20 20:27               ` [PATCH] Fix corrupt TCP packets when options space overflows with MD5SIG enabled (v2) Adam Langley
2008-06-28  2:47                 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080618.015206.22767411.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=agl@imperialviolet.org \
    --cc=billfink@mindspring.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).